fix: update import paths to resolve no-restricted-imports ESLint errors#866
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors imports from @rc-component/util to use named imports directly from the package instead of deep paths, while adding /* eslint-disable no-restricted-imports */ comments for remaining deep imports. The reviewer recommends replacing the blanket file-wide ESLint disable comments with targeted // eslint-disable-next-line comments to prevent accidentally bypassing the rule for future imports, and suggests combining duplicate import statements from @rc-component/util.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #866 +/- ##
=======================================
Coverage 99.72% 99.72%
=======================================
Files 26 26
Lines 729 729
Branches 201 201
=======================================
Hits 727 727
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (12)
✅ Files skipped from review due to trivial changes (6)
🚧 Files skipped from review as they are similar to previous changes (1)
Walkthrough该 PR 将多个文件的深层 ChangesImport Path Standardization to
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
src/Menu.tsxESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox. src/MenuItem.tsxESLint skipped: the ESLint configuration for this file references a package that is not available in the sandbox. src/SubMenu/PopupTrigger.tsxESLint skipped: the ESLint configuration for this file references a package that is not available in the sandbox.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Test plan
npm run compilelocally to verify build passes关联 pr:#864
Summary by CodeRabbit
Chores
Tests