Skip to content

Update ctrlm_thunder_plugin_powermanager.cpp #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jthomp007c wants to merge 8 commits into
base: support/1.1.11
Choose a base branch
from
+47 −12
Open

Update ctrlm_thunder_plugin_powermanager.cpp #193

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d98d86e
Update ctrlm_thunder_plugin_powermanager.cpp
jthomp007c Apr 3, 2026
d2329ca
Update ctrlm_thunder_plugin_powermanager.cpp
jthomp007c Apr 3, 2026
4176268
Update ctrlm_thunder_plugin_powermanager.cpp
jthomp007c Apr 3, 2026
11ea30b
Adding JSON string method to plugin
jthomp007c Apr 6, 2026
d35e7da
Update ctrlm_thunder_plugin.h
jthomp007c Apr 8, 2026
2a3bc2a
Update ctrlm_thunder_plugin.cpp
jthomp007c Apr 8, 2026
3fd1df7
Update ctrlm_thunder_plugin.h
jthomp007c Apr 8, 2026
ef652ff
Update ctrlm_thunder_plugin.h
jthomp007c Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/thunder/ctrlm_thunder_plugin_powermanager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,10 @@ bool ctrlm_thunder_plugin_powermanager_t::get_wakeup_reason_voice() {

sem_wait(&this->semaphore);
if(this->call_plugin("getLastWakeupReason", (void *)&params, (void *)&response)) {
wakeup_reason_voice = (0 == strncmp(response["result"].String().c_str(), "VOICE", 5));
XLOGD_DEBUG("voice_wakeup is %s", wakeup_reason_voice?"TRUE":"FALSE");
XLOGD_INFO("result received <%s>", response["result"].String().c_str());
XLOGD_INFO("wakeupReason received <%s>", response["wakeupReason"].String().c_str());
wakeup_reason_voice = (std::string(response["result"].String()) == "VOICE");
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getLastWakeupReason response handling should validate expected labels before indexing. The inline curl example above shows the response contains only result (e.g., "COLDBOOT"), so unconditionally reading/logging response["wakeupReason"] risks logging misleading data (or returning an empty string) when that label isn’t present. Consider checking response.HasLabel("result") (and "wakeupReason" only if the plugin actually returns it) and treating a missing/unknown payload as a malformed response like get_power_state() does.

Copilot uses AI. Check for mistakes.
XLOGD_DEBUG("voice_wakeup is %s", wakeup_reason_voice?"TRUE":"FALSE");
} else {
XLOGD_ERROR("getLastWakeupReason call failed");
}
Expand Down
Loading