test(syscall): test-open-family open/openat 28-module suite

test-suit/starryos/normal/qemu-smp1/bugfix/bug-open-eintr-not-implemented/c/CMakeLists.txt

@@ -0,0 +1,8 @@
+cmake_minimum_required(VERSION 3.20)
+project(bug-open-eintr-not-implemented C)
+set(CMAKE_C_STANDARD 11)
+set(CMAKE_C_STANDARD_REQUIRED ON)
+set(CMAKE_C_EXTENSIONS ON)
+add_executable(bug-open-eintr-not-implemented src/main.c)
+target_compile_options(bug-open-eintr-not-implemented PRIVATE -Wall -Wextra -Werror)
+install(TARGETS bug-open-eintr-not-implemented RUNTIME DESTINATION usr/bin)

test-suit/starryos/normal/qemu-smp1/bugfix/bug-open-eintr-not-implemented/c/src/main.c

@@ -0,0 +1,59 @@
+/*
+ * bug-open-eintr-not-implemented: blocking open(FIFO) interrupted by signal
+ * (no SA_RESTART) should fail with -1 EINTR. Starry doesn't deliver EINTR.
+ *
+ * man 2 open §"EINTR":
+ *   "EINTR — While blocked waiting to complete an open of a slow device
+ *    (e.g., a FIFO; see fifo(7)), the call was interrupted by a signal
+ *    handler; see signal(7)."
+ *
+ * Linux behavior (host/WSL2 verified):
+ *   FIFO O_RDONLY no writer + alarm(1) + SIGALRM(no SA_RESTART) → -1 EINTR
+ * StarryOS bug: signal doesn't interrupt the blocking open, or open returns
+ *   fd>=0 anyway.
+ *
+ * Note: requires starry signal subsystem to deliver signals to processes
+ *   blocked in syscall path AND handle EINTR return. May relate to FIFO
+ *   reader_count tracking (FIFO subsystem is incomplete).
+ */
+#define _GNU_SOURCE
+#include <errno.h>
+#include <fcntl.h>
+#include <signal.h>
+#include <stdio.h>
+#include <string.h>
+#include <sys/stat.h>
+#include <unistd.h>
+
+static volatile sig_atomic_t alrm_fired = 0;
+static void alrm_handler(int sig) { (void)sig; alrm_fired = 1; }
+
+int main(void)
+{
+    const char *fifo = "/tmp/bug_eintr_fifo";
+    unlink(fifo);
+    if (mkfifo(fifo, 0644) != 0) { perror("mkfifo"); return 1; }
+
+    struct sigaction sa = {0};
+    sa.sa_handler = alrm_handler;
+    sigemptyset(&sa.sa_mask);
+    sa.sa_flags = 0;  /* no SA_RESTART */
+    sigaction(SIGALRM, &sa, NULL);
+
+    alarm(2);  /* 2 sec to allow blocking open to be interrupted */
+    errno = 0;
+    int fd = open(fifo, O_RDONLY);  /* blocks waiting for writer */
+    int err = errno;
+    alarm(0);
+
+    int ok = (fd == -1 && err == EINTR);
+    if (ok) {
+        printf("PASS: open(FIFO RDONLY, no writer) interrupted by SIGALRM -> -1 EINTR\n");
+    } else {
+        printf("FAIL: expected -1 EINTR, got fd=%d errno=%d (%s) alrm_fired=%d\n",
+               fd, err, strerror(err), alrm_fired);
+    }
+    if (fd >= 0) close(fd);
+    unlink(fifo);
+    return ok ? 0 : 1;
+}

test-suit/starryos/normal/qemu-smp1/bugfix/bug-open-etxtbsy-not-implemented/c/CMakeLists.txt

@@ -0,0 +1,8 @@
+cmake_minimum_required(VERSION 3.20)
+project(bug-open-etxtbsy-not-implemented C)
+set(CMAKE_C_STANDARD 11)
+set(CMAKE_C_STANDARD_REQUIRED ON)
+set(CMAKE_C_EXTENSIONS ON)
+add_executable(bug-open-etxtbsy-not-implemented src/main.c)
+target_compile_options(bug-open-etxtbsy-not-implemented PRIVATE -Wall -Wextra -Werror)
+install(TARGETS bug-open-etxtbsy-not-implemented RUNTIME DESTINATION usr/bin)

test-suit/starryos/normal/qemu-smp1/bugfix/bug-open-etxtbsy-not-implemented/c/src/main.c

@@ -0,0 +1,38 @@
+/*
+ * bug-open-etxtbsy-not-implemented: open running self binary for write should
+ * fail with -1 ETXTBSY, but starry doesn't track text-busy → fd>=0 succeeds.
+ *
+ * man 2 open §"ETXTBSY":
+ *   "ETXTBSY — pathname refers to an executable image which is currently
+ *    being executed and write access was requested."
+ *
+ * Linux behavior (host/WSL2 verified): open(/proc/self/exe, O_WRONLY) → -1 ETXTBSY (errno 26)
+ * StarryOS bug: returns valid fd (no deny_write_access tracking on exec'd binary).
+ *
+ * Note: full Linux implementation requires kernel-side tracking via
+ * inode->i_writecount + deny_write_access() on exec, plus get_write_access
+ * checks on open. Starry's vfs lacks this entirely.
+ */
+#define _GNU_SOURCE
+#include <errno.h>
+#include <fcntl.h>
+#include <stdio.h>
+#include <string.h>
+#include <unistd.h>
+
+int main(void)
+{
+    /* Use /proc/self/exe symlink (works on both Linux and starry's procfs) */
+    errno = 0;
+    int fd = open("/proc/self/exe", O_WRONLY);
+    int err = errno;
+    int ok = (fd == -1 && err == ETXTBSY);
+    if (ok) {
+        printf("PASS: open(/proc/self/exe, O_WRONLY) -> -1 ETXTBSY\n");
+    } else {
+        printf("FAIL: expected -1 ETXTBSY, got fd=%d errno=%d (%s)\n",
+               fd, err, strerror(err));
+    }
+    if (fd >= 0) close(fd);
+    return ok ? 0 : 1;
+}

test-suit/starryos/normal/qemu-smp1/syscall/test-open-family/c/CMakeLists.txt

@@ -0,0 +1,48 @@
+cmake_minimum_required(VERSION 3.20)
+project(test-open-family C)
+set(CMAKE_C_STANDARD 11)
+set(CMAKE_C_STANDARD_REQUIRED ON)
+set(CMAKE_C_EXTENSIONS OFF)
+
+# 地毯式全覆盖 28 模块（按维度切分），每模块自计 __pass/__fail，main 汇总。
+# 见 notes/02 §17 + notes/10 §1.2。
+add_executable(test-open-family
+    src/main.c
+    src/helpers.c
+    src/open_access.c
+    src/open_mode_umask.c
+    src/open_create.c
+    src/open_excl.c
+    src/open_trunc.c
+    src/open_append.c
+    src/open_directory.c
+    src/open_nofollow.c
+    src/open_cloexec.c
+    src/open_nonblock.c
+    src/open_path.c
+    src/open_flag_matrix.c
+    src/open_silent_flags.c
+    src/open_fd_semantics.c
+    src/open_creat_alias.c
+    src/open_stress.c
+    src/open_err_efault.c
+    src/open_err_einval.c
+    src/open_err_enametoolong.c
+    src/open_err_eloop.c
+    src/open_err_eintr.c
+    src/open_err_enxio.c
+    src/open_err_etxtbsy.c
+    src/open_err_misc.c
+    src/openat_dirfd.c
+    src/openat_err.c
+    src/openat_flag_matrix.c
+    src/openat_creat.c)
+
+target_include_directories(test-open-family PRIVATE src)
+target_compile_options(test-open-family PRIVATE -Wall -Wextra -Werror)
+install(TARGETS test-open-family RUNTIME DESTINATION usr/bin/starry-test-suit)
+
+# cloexec helper binary 已回退（commit bc905... 后续）— 在 loongarch64 上
+# exec 该 helper 触发 user IllegalInstruction SIGILL，整个 test-open-family
+# 进程被终结。简化为 exec("/bin/true") 弱检查保 CI 稳定。真效果验证留
+# bug-* 或独立 PR。

test-suit/starryos/normal/qemu-smp1/syscall/test-open-family/c/src/helpers.c

@@ -0,0 +1,104 @@
+#define _GNU_SOURCE
+#include "helpers.h"
+
+#include <dirent.h>
+#include <errno.h>
+#include <fcntl.h>
+#include <stdio.h>
+#include <string.h>
+#include <sys/stat.h>
+#include <unistd.h>
+
+void cleanup_tree(const char *path)
+{
+    DIR *d = opendir(path);
+    if (d) {
+        struct dirent *e;
+        while ((e = readdir(d)) != NULL) {
+            if (!strcmp(e->d_name, ".") || !strcmp(e->d_name, ".."))
+                continue;
+            char child[1024];
+            snprintf(child, sizeof(child), "%s/%s", path, e->d_name);
+            struct stat st;
+            if (lstat(child, &st) == 0) {
+                if (S_ISDIR(st.st_mode))
+                    cleanup_tree(child);
+                else
+                    unlink(child);
+            }
+        }
+        closedir(d);
+    }
+    rmdir(path);
+    /* 顶层若是 symlink/普通文件，rmdir 不掉，再 unlink 兜底 */
+    unlink(path);
+}
+
+int ensure_dir(const char *path)
+{
+    if (mkdir(path, 0755) == 0) return 0;
+    if (errno == EEXIST) {
+        struct stat st;
+        if (stat(path, &st) == 0 && S_ISDIR(st.st_mode)) return 0;
+    }
+    return -1;
+}
+
+int write_file(const char *path, const void *content, size_t len, mode_t mode)
+{
+    unlink(path);
+    int fd = open(path, O_CREAT | O_WRONLY | O_TRUNC, mode);
+    if (fd < 0) return -1;
+    ssize_t off = 0;
+    while ((size_t)off < len) {
+        ssize_t n = write(fd, (const char *)content + off, len - off);
+        if (n <= 0) { close(fd); return -1; }
+        off += n;
+    }
+    close(fd);
+    /* O_CREAT mode 受 umask 影响，强制再 chmod 到目标 mode 以便测试 */
+    if (chmod(path, mode) != 0) return -1;
+    return 0;
+}
+
+ssize_t read_file(const char *path, char *buf, size_t buf_size)
+{
+    int fd = open(path, O_RDONLY);
+    if (fd < 0) return -1;
+    ssize_t total = 0;
+    while ((size_t)total + 1 < buf_size) {
+        ssize_t n = read(fd, buf + total, buf_size - 1 - total);
+        if (n < 0) { close(fd); return -1; }
+        if (n == 0) break;
+        total += n;
+    }
+    buf[total] = '\0';
+    close(fd);
+    return total;
+}
+
+mode_t get_file_mode(const char *path)
+{
+    struct stat st;
+    if (stat(path, &st) != 0) return (mode_t)-1;
+    return st.st_mode & 07777;
+}
+
+off_t get_file_size(const char *path)
+{
+    struct stat st;
+    if (stat(path, &st) != 0) return (off_t)-1;
+    return st.st_size;
+}
+
+int is_regular_file(const char *path)
+{
+    struct stat st;
+    return stat(path, &st) == 0 && S_ISREG(st.st_mode);
+}
+
+int is_directory(const char *path)
+{
+    struct stat st;
+    return stat(path, &st) == 0 && S_ISDIR(st.st_mode);
+}

test-suit/starryos/normal/qemu-smp1/syscall/test-open-family/c/src/helpers.h

@@ -0,0 +1,64 @@
+#pragma once
+/*
+ * helpers.h —— test-open-family 共享路径宏 + helper 函数原型。
+ *
+ * 全模块共用的全局 setup 路径 (OF_*) 在 main.c 的 global_setup() 里建好；
+ * 各模块在自己的 <module>_run() 开头另建 OF_MOD_<NAME> 私有目录，互不污染。
+ */
+
+#ifndef _GNU_SOURCE
+#define _GNU_SOURCE
+#endif
+
+#include <sys/types.h>
+#include <sys/stat.h>
+
+/* ── 全局共享只读路径（main.c global_setup() 建好）── */
+#define OF_DIR       "/tmp/topen"
+#define OF_REGULAR   OF_DIR "/regular"            /* 普通文件，内容 "hello" */
+#define OF_SUBDIR    OF_DIR "/subdir"             /* 子目录 */
+#define OF_SYMLINK   OF_DIR "/symlink_to_reg"     /* 指向 OF_REGULAR 的有效 symlink */
+#define OF_DANGLING  OF_DIR "/dangling"           /* 指向不存在路径的悬空 symlink */
+#define OF_SYM2DIR   OF_DIR "/symlink_to_dir"     /* 指向 OF_SUBDIR 的目录 symlink */
+
+/* 各模块私有目录命名约定，避免互相污染 */
+#define OF_MOD(name) "/tmp/topen_" name
+
+/* CHECK_QUIET: 仅在 FAIL 时打印，PASS 时只增计数器（用于 20k+ 断言的大矩阵，
+ * 避免 QEMU 串口被 PASS 行淹没拖慢）。要求宿主 TU 已 include test_framework.h
+ * 以提供 __pass / __fail static 计数器。 */
+#define CHECK_QUIET(cond, msg) do {                                     \
+    if (cond) {                                                         \
+        __pass++;                                                       \
+    } else {                                                            \
+        printf("  FAIL | %s:%d | %s | errno=%d (%s)\n",                \
+               __FILE__, __LINE__, msg, errno, strerror(errno));        \
+        __fail++;                                                       \
+    }                                                                   \
+} while(0)
+
+/* ── 通用 helper（实现见 helpers.c）── */
+
+/* 递归删除目录 path 下所有内容，再 rmdir(path)。失败静默忽略（防御性清理）。 */
+void cleanup_tree(const char *path);
+
+/* mkdir(path, 0755)；若已存在不报错。返回 0 OK / -1 fail。 */
+int ensure_dir(const char *path);
+
+/* 创建 path 内容为 content（长度 len）的普通文件，权限 mode。覆盖已存在。返回 0/-1。 */
+int write_file(const char *path, const void *content, size_t len, mode_t mode);
+
+/* 读 path 全部内容到 buf（最多 buf_size-1 字节，末尾置 \0）；返回读到字节数 / -1。 */
+ssize_t read_file(const char *path, char *buf, size_t buf_size);
+
+/* 取 path 的 stat.st_mode 低 12 位（07777 含 suid/sgid/sticky）；失败返 (mode_t)-1。 */
+mode_t get_file_mode(const char *path);
+
+/* 取 path 的 stat.st_size；失败返 -1。 */
+off_t get_file_size(const char *path);
+
+/* 文件存在且是普通文件返 1；否则 0。 */
+int is_regular_file(const char *path);
+
+/* 文件存在且是目录返 1；否则 0。 */
+int is_directory(const char *path);