-
Notifications
You must be signed in to change notification settings - Fork 126
feat(starry-perf): implement read for perf event fd #1400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -105,9 +105,24 @@ impl Pollable for PerfEvent { | |
| } | ||
| } | ||
|
|
||
| /// Stack buffer size for reading a single perf ringbuf record. The | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [note] 当前没有针对 perf event fd 建议后续添加一个使用 |
||
| /// ringbuf data region minimum is one page, and a single perf record | ||
| /// always fits within one data-region page. | ||
| const PERF_READ_BUF_SIZE: usize = PAGE_SIZE_4K; | ||
|
|
||
| impl FileLike for PerfEvent { | ||
| fn read(&self, _dst: &mut crate::file::IoDst) -> AxResult<usize> { | ||
| Err(AxError::Unsupported) | ||
| fn read(&self, dst: &mut crate::file::IoDst) -> AxResult<usize> { | ||
| let mut event = self.event.lock(); | ||
| let bpf_event = event | ||
| .as_any_mut() | ||
| .downcast_mut::<BpfPerfEventWrapper>() | ||
| .ok_or(AxError::Unsupported)?; | ||
| let mut buf = [0u8; PERF_READ_BUF_SIZE]; | ||
| let n = bpf_event.try_read_record(&mut buf)?; | ||
| if n == 0 { | ||
| return Ok(0); | ||
| } | ||
| dst.write(&buf[..n]).map_err(|_| AxError::Io) | ||
| } | ||
|
|
||
| fn write(&self, _src: &mut crate::file::IoSrc) -> AxResult<usize> { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit]
dst.as_ptr() as *const perf_event_header假设了 4 字节对齐,但dst是&mut [u8]仅保证 1 字节对齐。虽然栈上 4096 字节数组在实践中通常满足对齐要求,但严格来说这是 UB。建议使用
core::ptr::read_unaligned或确保缓冲区对齐: