feat(axbuild): improve incremental clippy coverage#1088
Merged
Conversation
YanLien
force-pushed
the
feat/clippy-since
branch
2 times, most recently
from
June 3, 2026 08:23
060e644 to
4245e5e
Compare
YanLien
force-pushed
the
feat/clippy-since
branch
from
June 3, 2026 09:03
4245e5e to
c19453c
Compare
ZR233
approved these changes
Jun 3, 2026
ZR233
left a comment
Member
There was a problem hiding this comment.
审查通过。
重点检查了增量 clippy 选择逻辑、三点 diff base 处理、直接 changed crate 的 --no-deps 检查、受影响顶层 crate 的 with-deps frontier 选择,以及 sync-lint/clippy 在 workflow 里直接传 --since 后的 fallback 行为。没有发现会漏检或破坏 CI 的阻塞问题。
本地验证:
cargo fmt --all -- --checkcargo test -p axbuild --lib -- --nocapture(477 passed)cargo xtask clippy --package axbuildcargo xtask sync-lint --since origin/devcargo xtask clippy --since origin/dev(选择 1 个 changed package 和 2 个 dependent top-level package,共 12 个 check,全部通过)- 额外探测:
cargo xtask sync-lint --since 0000000000000000000000000000000000000000会 fallback 到 full scan 并通过;cargo xtask clippy --since 0000000000000000000000000000000000000000已确认会 fallback 到 full workspace 后中断,避免跑完整 714 个 check。
远端 CI 当前通过。重复/重叠方面,base 里没有等价的三点 diff/frontier/timing 实现;open PR 中 #1031/#1024 只是在 ci.yml 不同区块有普通合并冲突风险,不是同一功能重复实现。
This was referenced Jun 3, 2026
Closed
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The previous clippy flow was too time-consuming for regular CI usage. Running broad clippy checks too often made feedback slower, while the incremental path still needed enough coverage to catch issues in crates affected by a change.
Changes
cargo xtask clippy --since <base>selection:cargo clippy --no-deps.--sinceso PR checks only consider changes from the current branch.cargo xtask clippy --alljob to.github/workflows/starry-apps.yml.CLAUDE.mdto remove staleclippy_crates.csvwhitelist references and document the current clippy flow.Rationale
The new flow keeps PR clippy cheaper by avoiding full-workspace checks on every run. Directly changed crates are checked with
--no-deps, while selected top-level affected crates run with deps to preserve coverage of the impacted dependency tree.The scheduled
clippy --alljob moves the expensive full-workspace check to a periodic workflow, so CI still gets full coverage without making every PR pay that cost.Three-dot diff avoids over-selecting crates when the base branch has moved, which prevents unnecessary extra clippy work and accidental full-workspace fallbacks.
Validation
cargo fmtcargo test -p axbuild --lib -- --nocapturecargo xtask clippy --package axbuild