Update roblox-creator-docs extension#27300
Conversation
- Merge branch \'contributions/merge-1776685433633\' - Pull contributions - update - update
|
Thank you for your contribution! 🎉 🔔 @choppedtuna you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. 📋 Quick checkout commandsBRANCH="ext/roblox-creator-docs"
FORK_URL="https://github.com/pernielsentikaer/raycast-extensions.git"
EXTENSION_NAME="roblox-creator-docs"
REPO_NAME="raycast-extensions"
git clone -n --depth=1 --filter=tree:0 -b $BRANCH $FORK_URL
cd $REPO_NAME
git sparse-checkout set --no-cone "extensions/$EXTENSION_NAME"
git checkout
cd "extensions/$EXTENSION_NAME"
npm install && npm run devWe're currently experiencing a high volume of incoming requests. As a result, the initial review may take up to 10-15 business days. |
Greptile SummaryThis PR adds Windows platform support to the Two concerns flagged in the prior review round remain unaddressed:
Confidence Score: 4/5Not safe to merge until the hardcoded CHANGELOG date and stale lock file are corrected. The package.json version bump was properly addressed from last round, but the two remaining P1-level findings (hardcoded date instead of {PR_MERGE_DATE}, and a stale-state package-lock.json with downgraded transitive deps) still need to be resolved before this can be merged cleanly. extensions/roblox-creator-docs/package-lock.json and extensions/roblox-creator-docs/CHANGELOG.md Important Files Changed
Reviews (2): Last reviewed commit: "Update package-lock.json" | Re-trigger Greptile |
| { | ||
| "name": "roblox-creator-docs", | ||
| "version": "1.0.2", | ||
| "version": "1.0.1", |
There was a problem hiding this comment.
package-lock.json version downgraded to 1.0.1 and multiple packages rolled back
The root version in package-lock.json was changed from 1.0.2 → 1.0.1, and numerous transitive packages (e.g. brace-expansion, minimatch, ajv, picomatch, flatted) were simultaneously downgraded to older versions. This suggests the lock file was regenerated from a stale state (perhaps from a different branch or an older node_modules). The lock file version must match package.json (1.0.2 or 1.1.0 once bumped), and rolling back transitive deps to older patches undoes previous security/bug fixes. Please regenerate the lock file from a clean install (rm package-lock.json && npm install) against the correct package.json.
Prompt To Fix With AI
This is a comment left during a code review.
Path: extensions/roblox-creator-docs/package-lock.json
Line: 3
Comment:
**`package-lock.json` version downgraded to `1.0.1` and multiple packages rolled back**
The root version in `package-lock.json` was changed from `1.0.2` → `1.0.1`, and numerous transitive packages (e.g. `brace-expansion`, `minimatch`, `ajv`, `picomatch`, `flatted`) were simultaneously downgraded to older versions. This suggests the lock file was regenerated from a stale state (perhaps from a different branch or an older `node_modules`). The lock file version must match `package.json` (`1.0.2` or `1.1.0` once bumped), and rolling back transitive deps to older patches undoes previous security/bug fixes. Please regenerate the lock file from a clean install (`rm package-lock.json && npm install`) against the correct `package.json`.
How can I resolve this? If you propose a fix, please make it concise.Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
|
This should be ready @0xdhrv 🙂 |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
0xdhrv
left a comment
There was a problem hiding this comment.
Looks good to me, approved ✅
|
Published to the Raycast Store: |
|
🎉 🎉 🎉 We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag. |
Description
Screencast
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare placed outside of themetadatafolder