Skip to content

[core] Pin legacy OOM killing policy in test_memory_pressure fixtures #62922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elliot-barn wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −0
Open

[core] Pin legacy OOM killing policy in test_memory_pressure fixtures #62922

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51453f2
[tests] Pin legacy OOM killing policy in test_memory_pressure fixtures
elliot-barn Apr 24, 2026
5049c59
Merge branch 'master' into elliot-barn-fix-test-memory-pressure-oom-p…
elliot-barn Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions python/ray/tests/test_memory_pressure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ def ray_with_memory_monitor(shutdown_only):
"task_oom_retries": task_oom_retries,
"min_memory_free_bytes": -1,
"task_oom_retry_delay_base_ms": 0,
# PR #62643 flipped the default OOM killing policy to the
# time-based multi-worker policy; these tests assert on
# single-worker, owner-group semantics.
"worker_killing_policy_by_group": True,
},
) as addr:
yield addr
Expand All @@ -70,6 +74,7 @@ def ray_with_memory_monitor_no_oom_retry(shutdown_only):
"task_oom_retries": 0,
"min_memory_free_bytes": -1,
"task_oom_retry_delay_base_ms": 0,
"worker_killing_policy_by_group": True,
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency and maintainability, it would be beneficial to add a comment here explaining why worker_killing_policy_by_group is set to True, similar to the one in the ray_with_memory_monitor fixture. This will help future developers understand the context for this configuration.

            # PR #62643 flipped the default OOM killing policy to the
            # time-based multi-worker policy; these tests assert on
            # single-worker, owner-group semantics.
            "worker_killing_policy_by_group": True

Copy link
Copy Markdown

@cursor cursor Bot Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed pinning legacy kill policy in inline ray.init test

Medium Severity

test_one_actor_max_lifo_kill_next_actor also asserts on legacy LIFO killing semantics (newest actor is killed, oldest survives) but its inline ray.init() _system_config was not updated with "worker_killing_policy_by_group": True. Since the default flipped to the time-based policy in PR #62643, this test is susceptible to the same regression the PR intends to fix — the assertions at lines 572–574 and 584–588 may fail under the new default policy.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 5049c59. Configure here.

},
) as addr:
yield addr
Expand Down
Loading