[release test] disable over-selection blocking by default#62694
Merged
aslonnie merged 3 commits intoray-project:masterfrom Apr 19, 2026
Merged
[release test] disable over-selection blocking by default#62694aslonnie merged 3 commits intoray-project:masterfrom
aslonnie merged 3 commits intoray-project:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a configurable threshold for manual test trigger confirmation via the --selection-block-threshold option, replacing the previous hardcoded value of 5. The feedback suggests simplifying the conditional logic used to determine whether to generate a confirmation block to improve readability.
Comment on lines
+191
to
+194
| is_automatic = os.environ.get("AUTOMATIC", "") == "1" | ||
| if not is_automatic and test_filters and selection_block_threshold > 0: | ||
| if len(tests) >= selection_block_threshold: | ||
| block_step = generate_block_step(len(tests)) |
Contributor
There was a problem hiding this comment.
The logic for determining is_automatic and the subsequent conditional check can be simplified to improve readability by combining the conditions.
Suggested change
| is_automatic = os.environ.get("AUTOMATIC", "") == "1" | |
| if not is_automatic and test_filters and selection_block_threshold > 0: | |
| if len(tests) >= selection_block_threshold: | |
| block_step = generate_block_step(len(tests)) | |
| if os.environ.get("AUTOMATIC", "") != "1" and test_filters and selection_block_threshold > 0 and len(tests) >= selection_block_threshold: | |
| block_step = generate_block_step(len(tests)) |
ray-gardener
Bot
added
core
requested by data team Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
aslonnie
force-pushed
the
lonnie-260416-noblock
branch
from
b35ab2a to
c31933c
Compare
bveeramani
approved these changes
Apr 17, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit ceb6afa. Configure here.
Signed-off-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com>
HLDKNotFound
pushed a commit
to chichic21039/ray
that referenced
this pull request
Apr 22, 2026
…t#62694) requested by data team Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requested by data team