Repository navigation
Conversation
|
PR author is not in the allowed authors list. |
Author
|
Bumping this in case it got lost. Happy to update if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore root references after the other object aliases. Otherwise a shared object replaced by a shorter-path representative loses its already-restored reference back to the root.
Adds regression tests for both property orders and dedupe settings, array roots and legacy metadata. The affected cases fail before the fix.
Tested on Node 22: full suite (92 passed, 1 existing skip, 1 todo), TypeScript build and repository benchmark. Also checked shared children through arrays, Maps and Sets using the built package.
Fixes #361