Add checkcode details to vuln attempt#226
Merged
adfoster-r7 merged 1 commit intorapid7:masterfrom Apr 17, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds persistence support for Metasploit module check results on vulnerability attempts so downstream consumers (e.g., console/UI) can display both the check outcome and its explanatory message.
Changes:
- Adds
check_code(string) andcheck_detail(text) columns tovuln_attempts. - Documents the new attributes on
Mdm::VulnAttempt. - Updates the dummy app’s
structure.sqlto reflect the schema change.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| spec/dummy/db/structure.sql | Updates dummy DB schema dump to include check_code/check_detail (but also introduces \\restrict/\\unrestrict directives). |
| db/migrate/20260411000000_add_check_code_to_vuln_attempts.rb | Migration adding the two new columns to vuln_attempts. |
| app/models/mdm/vuln_attempt.rb | YARD documentation for the new check_code and check_detail fields. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
17b1097 to
ce77064
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dwelch-r7
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed by rapid7/metasploit-framework#21307
Add check code details to the VulnAttempt model, so that these can be shown to the user: