Update validation for report_vuln

[adfoster-r7]

Continuation of #21314

Verification

Before

When report_vuln is called without a name option:

[-] Auxiliary failed: Msf::ValidationError Failed to report vuln for 10.0.0.10:80 to the database

After

Now:

[-] Auxiliary failed: ArgumentError report_vuln Missing required option :name

[g0tmi1k]

Idea: What if it would just default to "name" variable, if its not defined? That way, whatever module called it, its used?

[adfoster-r7]

Hm. It looks like there was only one module impacted by this in the codebase, which you've fixed now - so I think it's okay tightening things up here, but let me know your thoughts 🤔

There's the potential that external third party/private modules would be impacted by this change, but I guess there's no change in end user behavior there

[g0tmi1k]

Not sure if asking me, or others with more exp ;)

My 2 cents is that it makes sense that the module name matches the vuln, and I would rather it be one less thing to think about (and everything matches/lines up) - so I'm all for using defaults (and able to overwrite it if needed/wanted) - keep things consistent.

[adfoster-r7]

If we had more modules with this issue, I'd be tempted to have a fallback - but I think we should be good. If any user issues pop up, we can go with the defaults approach. I'm hoping since this always crashed previously, and now there's just a better error message, there shouldn't be any impact 🤞

[g0tmi1k]

For what its worth, a very rough grep search, 69 modules use name: name for report_vuln.

$ grep -R 'name: name' -B5 | grep 'report_vuln\|name:' | grep report_vuln | wc -l
      69
$ 

[adfoster-r7]

Thanks for taking a look! 💯

[cdelafuente-r7]

Release Notes

This adds extra validation to report_vuln and delete_vuln in Msf::DBManager::Vuln to make sure required field are present and avoid a crash.