Skip to content

def initialize(info = {})#21321

Closed
g0tmi1k wants to merge 1 commit intorapid7:masterfrom
g0tmi1k:initialize
Closed

def initialize(info = {})#21321
g0tmi1k wants to merge 1 commit intorapid7:masterfrom
g0tmi1k:initialize

Conversation

@g0tmi1k
Copy link
Copy Markdown
Contributor

@g0tmi1k g0tmi1k commented Apr 16, 2026

REF: #21256 (comment)

Following @bwatters-r7 suggestion, fixing rspec failure - in bulk

@github-actions
Copy link
Copy Markdown

Thanks for your pull request! As part of our landing process, we manually verify that all modules work as expected.

We've added the additional-testing-required label to indicate that additional testing is required before this pull request can be merged.
For maintainers, this means visiting here.

@bwatters-r7
Copy link
Copy Markdown
Contributor

I'm not sure that this is a good idea in bulk. When you moved the module in #21256, it caused new linting to run and I figured we should fix it there.

@bwatters-r7
Copy link
Copy Markdown
Contributor

Yeah; most of those old modules are failing for other reasons, too, now.
When someone makes significant changes to a module, we should make sure that it is up-to-date on the tests, but there's no reason to update this many modules for only one rspec check.

@github-project-automation github-project-automation Bot moved this from Todo to Done in Metasploit Kanban Apr 23, 2026
@g0tmi1k g0tmi1k deleted the initialize branch April 23, 2026 18:34
@g0tmi1k
Copy link
Copy Markdown
Contributor Author

g0tmi1k commented Apr 23, 2026

Gotcha - thanks @bwatters-r7.
Fair enough!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants