Add i18n to the main process#897
Merged
Merged
Conversation
Lezurex
force-pushed
the
i18n-main-process
branch
3 times, most recently
from
c517121 to
4a286a0
Compare
The main process was not i18n'ed until now. This includes the tray icon or the top menu bar. These would be displayed in English regardless of what language the user had selected. This change adds the setup for i18next to the main process as well. We now have shared i18next configuration for the renderer and main processes.
Additionally, improve Simplified Chinese translations. Co-authored-by: Lenny Angst <lenny@familie-angst.ch>
Lezurex
force-pushed
the
i18n-main-process
branch
from
4a286a0 to
85c4d34
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #897 +/- ##
==========================================
+ Coverage 49.65% 57.77% +8.11%
==========================================
Files 23 41 +18
Lines 876 1068 +192
Branches 285 289 +4
==========================================
+ Hits 435 617 +182
- Misses 367 375 +8
- Partials 74 76 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main process was not i18n'ed until now. This includes the tray icon
or the top menu bar. These would be displayed in English regardless of
what language the user had selected.
This change adds the setup for i18next to the main process as well. We
now have shared i18next configuration for the renderer and main.
Additionally, Chinese translation improvements were cherry-picked from
@ORyong s PR #895.