Don't crash when no database connection is present#16
Merged
rpbaltazar merged 1 commit intorails-on-services:developmentfrom Mar 22, 2020
Merged
Don't crash when no database connection is present#16rpbaltazar merged 1 commit intorails-on-services:developmentfrom
rpbaltazar merged 1 commit intorails-on-services:developmentfrom
Conversation
Contributor
|
Hi @arthurWD. |
Contributor
|
What you did makes sense to me. Tests are failing in the CI. Are you able to reproduce the errors on your end? |
Contributor
|
Ok. Nevermind. I see the only suite is failing is an old version that I won't be supporting in the coming versions. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a couple of PR's in the original repo to fix crashes when no db is present.
Some other proposed sollutions are influitive#614, influitive#608, influitive#590