Prepare Release - 2.8.0

[rpbaltazar]

• Resolves Improve changelog automatic generation #98 - Trying to generate an automatic changelog - [#98] improve changelog automatic generation #99
• Resolves error running db:seed task #86 - Fixes seeding errors - [Resolves #86] error running db seed task #87
• Resolves Use a transaction for Apartment::Tenant.create #66 - Uses a transaction to create a tenant - [Resolves #66] Wrap tenant creation arount transaction #69
• Resolves Rails 6.1 compatibility #121 - Relaxes dependencies to allow rails 6.1 - Relaxes requirements on Rails to make it compatible with Rails 6.1 #122
• Resolves Tenant creation in transaction makes some test cases fail #123 - When tests run in a transaction, new tenants in tests fail to create - check if there is an open transaction #124
• Reverted unsafe initializer - Revert unsafe initializer #118

[rpbaltazar]

@lunks and @louim if you have a chance to test the development version against your platforms, i'd appreciate. I've ran it against ours and all tests are green, so i'd be happy to release this.

[lunks]

You should add my PR to the list too, it was on master before. I'll test it when I have a chance.

[lunks]

@rpbaltazar I'd like to talk about the error when trying to create an already existent schema.

The one that starts with:

Creating localhost tenant                                                                                                           
Could not log "sql.active_record" event. ActiveRecord::StatementInvalid: PG::InFailedSqlTransaction: ERROR:  current transaction is 
aborted, commands ignored until end of transaction block                                                                            
 ["/Users/lunks/.asdf/installs/ruby/2.7.2/lib/ruby/gems/2.7.0/gems/rack-mini-profiler-2.2.0/lib/patches/db/pg.rb:110:in `exec'", "/U
sers/lunks/.asdf/installs/ruby/2.7.2/lib/ruby/gems/2.7.0/gems/rack-mini-profiler-2.2.0/lib/patches/db/pg.rb:110:in `async_exec'", "/
Users/lunks/.asdf/installs/ruby/2.7.2/lib/ruby/gems/2.7.0/gems/activerecord-6.0.3.4/lib/active_record/connection_adapters/postgresql
/database_statements.rb:65:in `block (2 levels) in query'", "/Users/lunks/.asdf/installs/ruby/2.7.2/lib/ruby/gems/2.7

Two things concern me on it:

• Could not log "sql.active_record" event looks like an error that should be fixed.
• The whole stack trace output might not be an error and expected, but it's confusing to me as an user. Ideally we should supress it but I wonder if we're doing something wrong given any commands will be ignored for this transaction.

[rpbaltazar]

You should add my PR to the list too, it was on master before. I'll test it when I have a chance.

I've picked them and added it to the development branch, else we'd have a bunch of unresolved conflicts.

[rpbaltazar]

I looked at this and it seems to be a side consequence of failing to create the tenant. The Logger is rescuing all exceptions and logging all that output that you see, including the stack trace.

https://api.rubyonrails.org/v5.1.7/classes/ActiveSupport/LogSubscriber.html#method-i-finish

I'm curious about the tenant creation error. Is that on purpose for demoing the sql.active_error logging problems or something related to the current development branch?

[lunks]

You should add my PR to the list too, it was on master before. I'll test it when I have a chance.

I've picked them and added it to the development branch, else we'd have a bunch of unresolved conflicts.

I mean, to the changelog.

[rpbaltazar]

@rpbaltazar I'd like to talk about the error when trying to create an already existent schema.

@lunks just to make sure, was this an expected error that you wanted to show me the log for or was an unexpected error and the log was just a side thing?

[lunks]

@rpbaltazar I'd like to talk about the error when trying to create an already existent schema.

@lunks just to make sure, was this an expected error that you wanted to show me the log for or was an unexpected error and the log was just a side thing?

The error is expected (my tenant already exists) but it's pretty bad to have it shown like that. I think we should solve the active record log issue and handle this error more gracefully so users don't panic when seeing it.

[rpbaltazar]

The error is expected (my tenant already exists) but it's pretty bad to have it shown like that. I think we should solve the active record log issue and handle this error more gracefully so users don't panic when seeing it.

all clear. I think that for the sake of moving forward, we can open a ticket to address this and in the meantime release the gem version that fixes the unsafe initializer, which seems a more concerning issue

[lunks]

The error is expected (my tenant already exists) but it's pretty bad to have it shown like that. I think we should solve the active record log issue and handle this error more gracefully so users don't panic when seeing it.

all clear. I think that for the sake of moving forward, we can open a ticket to address this and in the meantime release the gem version that fixes the unsafe initializer, which seems a more concerning issue

Feel free to do so!