Skip to content

clean code #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
9bany merged 1 commit into from
Dec 30, 2025
Merged

clean code #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
101 changes: 7 additions & 94 deletions gamm/repo.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ pub struct Repo {
pub commit_by: String,
}

/// Store for managing repository ownership mappings
/// Store for managing repository ownership mappingsz
#[derive(Debug, Default, Serialize, Deserialize)]
pub struct RepoStore {
/// Maps remote URL -> Repo
Expand All @@ -48,8 +48,9 @@ impl RepoStore {

/// Load store from the default repos file, or create new if it doesn't exist
pub fn load() -> io::Result<Self> {
let path = Self::repos_path()
.ok_or_else(|| io::Error::new(io::ErrorKind::NotFound, "Could not find config directory"))?;
let path = Self::repos_path().ok_or_else(|| {
io::Error::new(io::ErrorKind::NotFound, "Could not find config directory")
})?;

if path.exists() {
let contents = fs::read_to_string(&path)?;
Expand All @@ -62,8 +63,9 @@ impl RepoStore {

/// Save store to the default repos file
pub fn save(&self) -> io::Result<()> {
let dir = Self::config_dir()
.ok_or_else(|| io::Error::new(io::ErrorKind::NotFound, "Could not find config directory"))?;
let dir = Self::config_dir().ok_or_else(|| {
io::Error::new(io::ErrorKind::NotFound, "Could not find config directory")
})?;
let path = Self::repos_path().unwrap();

// Create directory if it doesn't exist
Expand All @@ -80,40 +82,17 @@ impl RepoStore {
self.repos.insert(repo.url.clone(), repo);
}

/// Add a new repo by individual fields
pub fn add_repo(&mut self, repo_name: impl Into<String>, url: impl Into<String>, commit_by: impl Into<String>) {
let url = url.into();
self.repos.insert(
url.clone(),
Repo {
repo_name: repo_name.into(),
url,
commit_by: commit_by.into(),
},
);
}

/// Look up who owns the repo by remote URL
/// Returns the commit_by (config profile name) if found
pub fn lookup_owner_by_url(&self, url: &str) -> Option<&str> {
self.repos.get(url).map(|r| r.commit_by.as_str())
}

/// Get a repo by its remote URL
pub fn get_by_url(&self, url: &str) -> Option<&Repo> {
self.repos.get(url)
}

/// Remove a repo by its URL
pub fn remove_by_url(&mut self, url: &str) -> Option<Repo> {
self.repos.remove(url)
}

/// List all repo URLs
pub fn list_urls(&self) -> impl Iterator<Item = &String> {
self.repos.keys()
}

/// Iterate over all repos
pub fn iter(&self) -> impl Iterator<Item = (&String, &Repo)> {
self.repos.iter()
Expand All @@ -140,35 +119,6 @@ mod tests {
}
}

#[test]
fn test_new_store_is_empty() {
let store = RepoStore::new();
assert_eq!(store.list_urls().count(), 0);
}

#[test]
fn test_add_and_get_repo() {
let mut store = RepoStore::new();
store.add(sample_repo());

let repo = store.get_by_url("git@github.com:9bany/gam.git");
assert!(repo.is_some());

let repo = repo.unwrap();
assert_eq!(repo.repo_name, "gam");
assert_eq!(repo.commit_by, "personal");
}

#[test]
fn test_add_repo_by_fields() {
let mut store = RepoStore::new();
store.add_repo("my-project", "git@github.com:user/project.git", "work");

let repo = store.get_by_url("git@github.com:user/project.git");
assert!(repo.is_some());
assert_eq!(repo.unwrap().commit_by, "work");
}

#[test]
fn test_lookup_owner_by_url() {
let mut store = RepoStore::new();
Expand All @@ -181,43 +131,6 @@ mod tests {
assert!(owner.is_none());
}

#[test]
fn test_remove_repo() {
let mut store = RepoStore::new();
store.add(sample_repo());

let removed = store.remove_by_url("git@github.com:9bany/gam.git");
assert!(removed.is_some());
assert!(store.get_by_url("git@github.com:9bany/gam.git").is_none());
}

#[test]
fn test_find_by_owner() {
let mut store = RepoStore::new();
store.add_repo("project1", "url1", "work");
store.add_repo("project2", "url2", "work");
store.add_repo("project3", "url3", "personal");

let work_repos = store.find_by_owner("work");
assert_eq!(work_repos.len(), 2);

let personal_repos = store.find_by_owner("personal");
assert_eq!(personal_repos.len(), 1);
}

#[test]
fn test_serialize_deserialize() {
let mut store = RepoStore::new();
store.add(sample_repo());

let json = serde_json::to_string(&store).unwrap();
let restored: RepoStore = serde_json::from_str(&json).unwrap();

let repo = restored.get_by_url("git@github.com:9bany/gam.git").unwrap();
assert_eq!(repo.repo_name, "gam");
assert_eq!(repo.commit_by, "personal");
}

#[test]
fn test_repos_path_exists() {
let path = RepoStore::repos_path();
Expand Down