Skip to content

feat: add disable sleep item - #116

Merged
RadxaYuntian merged 1 commit into
radxa-pkg:mainfrom
xzl01:main
Dec 22, 2025
Merged

RadxaYuntian merged 1 commit into
radxa-pkg:mainfrom
xzl01:main

Conversation

@xzl01

@xzl01 xzl01 commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@xzl01
xzl01 requested a review from RadxaYuntian as a code owner December 18, 2025 09:02
@github-actions

Copy link
Copy Markdown
Contributor

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

Comment thread src/usr/lib/rsetup/cli/sleep-toggle.sh Outdated
Comment thread src/usr/lib/rsetup/cli/sleep-toggle.sh Outdated
Comment thread src/usr/lib/rsetup/tui/system/system.sh Outdated
@xzl01
xzl01 force-pushed the main branch 4 times, most recently from 4d8f1f1 to 8da4ef5 Compare December 18, 2025 11:53
@xzl01
xzl01 requested a review from RadxaYuntian December 18, 2025 12:01
Comment thread src/usr/lib/rsetup/cli/system.sh Outdated
Comment thread src/usr/lib/rsetup/tui/system/system.sh
Comment thread src/usr/lib/rsetup/tui/system/system.sh Outdated
Comment thread src/usr/lib/rsetup/cli/system.sh Outdated
Comment thread src/usr/lib/rsetup/cli/system.sh
Comment thread src/usr/lib/rsetup/mod/suspend.sh Outdated
Comment thread src/usr/lib/rsetup/mod/suspend.sh Outdated
Comment thread src/usr/lib/rsetup/mod/suspend.sh Outdated
@CodeChenL

Copy link
Copy Markdown
Contributor

@xzl01 我目前想给radxa-system-config-amlogic添加依赖radxa-system-config-gdm3-disable-sleep来默认禁用gdm3的休眠
请问这里的修改主要意思是用户可以动态修改吗,是否与radxa-system-config-gdm3-disable-sleep兼容

@xzl01

xzl01 commented Dec 19, 2025 •

Copy link
Copy Markdown
Contributor Author

@xzl01 我目前想给radxa-system-config-amlogic添加依赖radxa-system-config-gdm3-disable-sleep来默认禁用gdm3的休眠 请问这里的修改主要意思是用户可以动态修改吗,是否与radxa-system-config-gdm3-disable-sleep兼容

1 是的,因为部分休眠正常的机器,用户用作无头服务器的时候会被休眠干扰,而且如果是gdm+kde的组合会不知道到哪去修改休眠配置,这里的修改就是提供给用户一个一键开关的配置 2.不兼容,如果用户手动在这里打开了休眠,是会enbale休眠的。

@xzl01
xzl01 requested a review from RadxaYuntian December 19, 2025 08:16
@CodeChenL

Copy link
Copy Markdown
Contributor

@xzl01 我目前想给radxa-system-config-amlogic添加依赖radxa-system-config-gdm3-disable-sleep来默认禁用gdm3的休眠 请问这里的修改主要意思是用户可以动态修改吗,是否与radxa-system-config-gdm3-disable-sleep兼容

1 是的,因为部分休眠正常的机器,用户用作无头服务器的时候会被休眠干扰,而且如果是gdm+kde的组合会不知道到哪去修改休眠配置,这里的修改就是提供给用户一个一键开关的配置 2.不兼容,如果用户手动在这里打开了休眠,是会enbale休眠的。

只要不影响开机时的默认配置并且可正常开关即可,用户后续如何设置就不管了

@RadxaYuntian

Copy link
Copy Markdown
Member
  1. PR修改期间请不要force push,审核起来不好对比和上一次之前修改的差异。一般是代码都确认没问题才在最后修改提交历史
  2. PR修改建议不需要回复,默认是会在下一次request review时会改好。除非是对于代码建议有异议,那可以直接在上面沟通
  3. 不要手动resolve conversation,我会在下一次审核时对照检查是否有更正。特例是有代码建议的那种,如果使用apply code suggestion会自动关闭,这种不属于手动点击resolve conversation所以是OK的。本质上是如果修改来源是审核者就可以自动resolve,如果修改来源是PR作者就需要保持打开,所以code suggestion如果不完整/是伪代码也不应该apply

@RadxaYuntian

Copy link
Copy Markdown
Member

并且force push后修改过代码不会继承之前的审查意见,丢失了上下文

Comment thread src/usr/lib/rsetup/tui/system/system.sh Outdated
Comment thread src/usr/lib/rsetup/cli/system.sh
Comment thread src/usr/lib/rsetup/cli/system.sh Outdated
@xzl01
xzl01 requested a review from RadxaYuntian December 22, 2025 02:14

@RadxaYuntian RadxaYuntian left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

整理一下提交吧

@RadxaYuntian
RadxaYuntian merged commit 724d3bc into radxa-pkg:main Dec 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants