Skip to content

argocd prototype - #13525

Draft
nithyatsu wants to merge 7 commits into
mainfrom
nithyatsu-argocd-prototype
Draft

nithyatsu wants to merge 7 commits into
mainfrom
nithyatsu-argocd-prototype

Conversation

@nithyatsu

Copy link
Copy Markdown
Contributor

Summary

Reason for change

Fixes #

How to test

File change summary

File Summary of change

nithyatsu and others added 5 commits October 26, 2026 10:48
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Nithya Subramanian <nithyasu@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Nithya Subramanian <nithyasu@microsoft.com>
…lth check

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Nithya Subramanian <nithyasu@microsoft.com>
…king

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Nithya Subramanian <nithyasu@microsoft.com>
The controller now sets radapp.io/resource-type and radapp.io/phrase on each
DeploymentResource. Argo CD's resource.customLabels shows them as tile chips.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Nithya Subramanian <nithyasu@microsoft.com>
@nithyatsu nithyatsu changed the title Nithyatsu argocd prototype argocd prototype Oct 27, 2026
@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions

Copy link
Copy Markdown

This PR requires exactly 1 of the following labels: pr:standard, pr:important.
Currently applied labels: .

Label descriptions:

  • pr:important - Major features, breaking changes, deprecations, or other high-impact changes that need special attention during release and in release notes.
  • pr:standard - Ongoing maintenance, minor improvements, documentation updates, and routine development work.

@nithyatsu, please add the appropriate label to this PR before merging.

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Unit Tests

    2 files  ± 0    420 suites  ±0   20m 29s ⏱️ + 3m 59s
7 814 tests +20  7 812 ✅ +20  2 💤 ±0  0 ❌ ±0 
8 984 runs  +20  8 982 ✅ +20  2 💤 ±0  0 ❌ ±0 

Results for commit 5f83378. ± Comparison against base commit 7bcdd7a.

♻️ This comment has been updated with latest results.

@codecov

codecov Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.96721% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.07%. Comparing base (200f604) to head (5f83378).
⚠️ Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
...troller/reconciler/deploymenttemplate_untracked.go 64.70% 12 Missing ⚠️
...roller/reconciler/deploymenttemplate_reconciler.go 69.23% 4 Missing ⚠️
...roller/reconciler/deploymentresource_reconciler.go 76.92% 3 Missing ⚠️
...ntroller/reconciler/deploymenttemplate_progress.go 90.00% 2 Missing ⚠️
...roller/reconciler/deploymenttemplate_apiversion.go 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13525      +/-   ##
==========================================
+ Coverage   68.72%   69.07%   +0.34%     
==========================================
  Files         732      737       +5     
  Lines       40159    40303     +144     
==========================================
+ Hits        27599    27838     +239     
+ Misses      12560    12465      -95     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nithyatsu and others added 2 commits October 27, 2026 14:48
Annotate owned DeploymentResources with radapp.io/deploying-generation while
a DeploymentTemplate deploys, mirror it in the phrase label, and map it to
Progressing in the Argo CD health check.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Nithya Subramanian <nithyasu@microsoft.com>
… fix delete API version

- radius-generate.sh: with one bicepFiles entry, name the DeploymentTemplate after ARGOCD_APP_NAME.
- Controller: create no DeploymentResource for Radius.Core output resources; delete them
  when the DeploymentTemplate is deleted, applications before environments before recipe packs.
- Controller: delete resources with the API version the template deployed them with,
  instead of 2023-10-01-preview, which Radius.* types reject.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Nithya Subramanian <nithyasu@microsoft.com>
@github-actions

Copy link
Copy Markdown

❌ Spellcheck Failed

There are spelling errors in your PR. Visit the workflow output to see what words are failing.

Adding new words

You can add new custom words to .cspellignore.

@radius-functional-tests

radius-functional-tests Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Radius functional test overview

🔍 Go to test action run

Click here to see the test run details
Name Value
Repository radius-project/radius
Commit ref 5f83378
Unique ID func8013edc83a
Image tag test-func8013edc83a-40754854161-1
  • Dapr: 1.14.4
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:test-func8013edc83a-40754854161-1
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:test-func8013edc83a-40754854161-1
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:test-func8013edc83a-40754854161-1
  • controller test image location: ghcr.io/radius-project/dev/controller:test-func8013edc83a-40754854161-1
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:test-func8013edc83a-40754854161-1
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant