Skip to content

test(recipes): re-enable custom terraform recipe functional test - #13312

Merged
nicolejms merged 2 commits into
mainfrom
nicolejms-enable-terraform-recipe-functional-test
Oct 15, 2026
Merged

nicolejms merged 2 commits into
mainfrom
nicolejms-enable-terraform-recipe-functional-test

Conversation

@nicolejms

Copy link
Copy Markdown
Contributor

Summary

Removes the t.Skip for the custom subtest in the Terraform recipe cloud functional test, now that #13300 fixes terraform get rejecting modules with provider configuration_aliases.

Reason for change

The skip referenced #13299. #13300 merged the fix, and this follow-up re-enables the test so the cloud functional run verifies the custom subtest end to end.

Fixes #13299

How to test

Run the cloud functional tests (recipe_terraform_test.go, Test_TerraformRecipe_AzureResourceGroup or equivalent) in CI; the custom subtest should now run and pass.

File change summary

File Summary of change
test/functional-portable/corerp/cloud/resources/recipe_terraform_test.go Remove t.Skip for the custom subtest.

@nicolejms
nicolejms requested review from a team as code owners October 15, 2026 17:47
Copilot AI balanced review requested due to automatic review settings October 15, 2026 17:47
@github-actions github-actions Bot added the pr:waiting-for-review A reviewer owns the next action; required approval is pending or unverifiable label Oct 15, 2026
@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions

Copy link
Copy Markdown

Thank you for contributing to Radius.

The following commits do not currently show a GitHub Verified signature:

Please follow our commit-signing guide to configure GPG, SSH, or S/MIME signing. Then re-sign the affected commits and force-push the rewritten branch with --force-with-lease.

Cryptographic commit signing is separate from the DCO Signed-off-by line; both are required.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Nicole James <nicolej@microsoft.com>
@nicolejms
nicolejms force-pushed the nicolejms-enable-terraform-recipe-functional-test branch from 19bbf49 to 962098b Compare October 15, 2026 17:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The targeted skip removal matches the merged fix; only a nonblocking documentation correction remains.

1 open finding
What changed in this PR

Restores cloud functional coverage for custom Terraform provider aliases following the fix in #13300.

Changes:

  • Removes the custom subtest’s skip in Test_TerraformRecipe_AzureResourceGroup, enabling its deployment and cleanup checks.
File Description
test/​functional-portable/​corerp/​cloud/​resources/​recipe_terraform_test.go Re-enables the custom provider alias subtest.

🧠 Review effort: Balanced


💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Nicole James <nicolej@microsoft.com>
@nicolejms nicolejms added the pr:standard Ongoing maintenance, minor improvements, documentation updates, and routine development work label Oct 15, 2026
@github-actions github-actions Bot added pr:review-approved Required reviews are approved; checks may still be pending and removed pr:waiting-for-review A reviewer owns the next action; required approval is pending or unverifiable labels Oct 15, 2026
@nicolejms
nicolejms enabled auto-merge October 15, 2026 18:00
@github-actions

Copy link
Copy Markdown

Unit Tests

    2 files  ±0    448 suites  ±0   17m 46s ⏱️ + 2m 32s
7 431 tests ±0  7 429 ✅ ±0  2 💤 ±0  0 ❌ ±0 
8 864 runs  ±0  8 862 ✅ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 651ad58. ± Comparison against base commit 2836d26.

@codecov

codecov Bot commented Oct 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.74%. Comparing base (2836d26) to head (651ad58).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13312   +/-   ##
=======================================
  Coverage   60.74%   60.74%           
=======================================
  Files         772      772           
  Lines       45687    45687           
=======================================
  Hits        27753    27753           
  Misses      17934    17934           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@radius-functional-tests

radius-functional-tests Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Radius functional test overview

🔍 Go to test action run

Click here to see the test run details
Name Value
Repository radius-project/radius
Commit ref 651ad58
Unique ID funcb146b95a67
Image tag pr-funcb146b95a67
  • Dapr: 1.14.4
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcb146b95a67
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcb146b95a67
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcb146b95a67
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcb146b95a67
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcb146b95a67
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@nicolejms
nicolejms added this pull request to the merge queue Oct 15, 2026
Merged via the queue into main with commit bed53d2 Oct 15, 2026
96 checks passed
@nicolejms
nicolejms deleted the nicolejms-enable-terraform-recipe-functional-test branch October 15, 2026 19:23
@github-actions github-actions Bot removed the pr:review-approved Required reviews are approved; checks may still be pending label Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:standard Ongoing maintenance, minor improvements, documentation updates, and routine development work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terraform recipes fail when the module declares provider configuration_aliases

3 participants