ci: harden release discovery and snapshot builds - #12970
Draft
DariuszPorowski wants to merge 1 commit into
Draft
DariuszPorowski wants to merge 1 commit into
DariuszPorowski wants to merge 1 commit into
Conversation
Allow tag-build discovery five minutes, isolate snapshot CLI SBOM scans from network enrichment, and retain Bicep separately from core snapshot images. Implement follow-up items 3 and 6 plus the snapshot-isolation portion of item 5. Keep the image scanner pin deferred as planned. Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
DariuszPorowski
added this pull request to stack #12738
September 12, 2026 17:01
DariuszPorowski
marked this pull request as draft
September 12, 2026 17:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the first hardening bundle from the GoReleaser stack follow-up plan as a dependent layer above #12956: items 3 and 6, plus the CLI snapshot-isolation portion of item 5. The image-scanner digest pin remains deferred until after the first RC/final cycle, as planned.
--enrich golangfor releases.bicep-image-<version>in the image-export job. Core images remain available incore-snapshot-images-<sha>.Reason for change
Avoid false controller failures when GitHub schedules tag builds slowly, remove the Go module proxy from snapshot SBOM generation, and stop uploading the same core images twice. Keep this follow-up isolated from the eighteen existing stack layers and leave release identity policy and image-attestation generation unchanged.
How to test
Passed locally:
The dispatcher suite passes 7 tests, controller contracts pass 41 checks, and cutover contracts pass 11 tests. The SBOM suite covers snapshot, explicit release, unset snapshot mode, paths with spaces, distribution-directory execution, and scanner exit-code propagation.
Also passed a real GoReleaser/Syft snapshot smoke test using a disposable one-binary Go-module fixture inside an isolated network namespace with
GOPROXY=http://127.0.0.1:1. The generated SPDX SBOM includes the fixture's module dependency.Markdown lint/table checks, JavaScript formatting, and wrapper/test shell formatting pass. Actionlint passes with only its known unsupported existing
concurrency.queuediagnostic excluded; no repository lint suppression was added.Full multi-architecture Docker builds and cspell were not run locally because those tools are unavailable in the validation environment. CI still needs to validate the full workflows.
File change summary