Align missing namespace test with stock ARM errors - #12940
Draft
willdavsmith wants to merge 1 commit into
Draft
Conversation
Expect the stock ARM ResourceDeploymentFailure wrapper around the existing BadRequest detail. Copilot-Session: 816c511c-1b15-47e4-b936-34e2f7bf2c1c Signed-off-by: willdavsmith <willdavsmith@gmail.com>
Radius functional test overviewClick here to see the test run details
Test Status⌛ Building Radius and pushing container images for functional tests... |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12940 +/- ##
=======================================
Coverage 59.82% 59.82%
=======================================
Files 779 779
Lines 46058 46058
=======================================
Hits 27555 27555
Misses 18503 18503 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📊 Application Graph Diff
Comparing
main→willdavsmith-stock-error-assertion✅ No application graph changes detected. The application model is identical between
mainandwilldavsmith-stock-error-assertion.graph TD classDef added fill:#dafbe1,stroke:#1a7f37,stroke-width:2px,color:#1a7f37 classDef removed fill:#ffebe9,stroke:#cf222e,stroke-width:2px,color:#cf222e classDef modified fill:#fff8c5,stroke:#bf8700,stroke-width:2px,color:#9a6700 classDef unchanged fill:#f6f8fa,stroke:#d1d9e0,stroke-width:1px,color:#656d76 repo_radius_state_container["repo-radius-state-container\ncontainers"]:::unchangedSummary
Update the modern UDT recipe pack missing-namespace functional test to expect the standard stock ARM deployment error hierarchy:
DeploymentFailed→ResourceDeploymentFailure→BadRequest.This preserves the existing namespace-missing message assertion and aligns the test with the stock
Azure.Deployments.Enginesemantics introduced by azure-octo/deployment-engine#637. It does not change Deployment Engine behavior or deprecatedApplications.*assertions.Validation
gofmt -w test/functional-portable/dynamicrp/noncloud/resources/recipepacks_test.gogo test ./test/functional-portable/dynamicrp/noncloud/resources -run '^$'