Delete functional test resources in dependency order to fix LRT

[brooke-hamilton]

Description

Test_RadiusCore_AzureMySql_PortalLink fails in the scheduled long-running test (LRT) during cleanup because the test deletes its environment and recipe pack before deleting the application. Application deletion cascades into the recipe-backed Radius.Data/mySqlDatabases resource, whose delete operation still needs the environment configuration to run terraform destroy; the missing environment produces an Internal error wrapping NotFound.

Why pull request CI did not catch it

The cloud and non-cloud functional workflows set RADIUS_TEST_FAST_CLEANUP=true, which starts deletion in background goroutines and discards their errors. The LRT uses standard cleanup on a persistent cluster and therefore surfaces the failure. The LRT also executes tests from the current official release rather than main, so the released test must be temporarily skipped until a release includes this fix.

Changes

• Reorder the MySQL portal-link test resources so the application and database are deleted before the environment and recipe pack.
• Add validation.ResourcesInDeletionOrder, which orders teardown as applications, application-scoped resources, environments, then recipe packs while preserving declaration order within each group.
• Make cleanup safe when a test step has a nil resource set.
• Add table-driven unit coverage for ordering, stable groups, case-insensitive type matching, nil and empty inputs, unknown resource types, and input preservation.
• Correct the functional-test cleanup documentation and document dependency-ordered teardown.
• Skip Test_RadiusCore_AzureMySql_PortalLink in the released LRT suite until a release contains the fix.

Validation

• The target test passed with RADIUS_TEST_FAST_CLEANUP=false in 271 seconds. That cloud run later failed only on unrelated AWS deletion assertions: https://github.com/radius-project/radius/actions/runs/32422259142
• The complete branch LRT against v0.60 succeeded with the temporary released-test skip, including diagnostics and persistent-cluster cleanup: https://github.com/radius-project/radius/actions/runs/32425245273
• Unit tests, lint, builds, CodeQL, dependency review, and the remaining functional suites pass.
• The latest corerp-cloud run and its failed-job rerun were red only because the unrelated Test_AWS_LogsLogGroup AWS deletion waiter reported an already-absent resource as still present; neither failure involved the MySQL portal-link test or the changed cleanup ordering.

Type of change

• This pull request fixes a bug in Radius and has an approved issue (Scheduled long running test did not complete successfully - Run ID: 32125249323 #12701).

Fixes: #12701

Contributor checklist

• Existing functional tests updated as required by this change.
• Unit tests added for the cleanup-order helper.
• Contributor documentation updated.
• The standard-cleanup path and released LRT workflow validated.

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

[github-actions]

Unit Tests

    2 files  ±0    457 suites  ±0   7m 41s ⏱️ +10s
6 312 tests ±0  6 310 ✅ ±0  2 💤 ±0  0 ❌ ±0 
7 570 runs  ±0  7 568 ✅ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 3abed10. ± Comparison against base commit b0875a4.

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.41%. Comparing base (b0875a4) to head (3abed10).

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #12702      +/-   ##
==========================================
- Coverage   54.41%   54.41%   -0.01%     
==========================================
  Files         770      770              
  Lines       51371    51371              
==========================================
- Hits        27955    27953       -2     
- Misses      20799    20800       +1     
- Partials     2617     2618       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Functional Tests - daprrp-noncloud

26 tests  ±0   26 ✅ ±0   13m 21s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 707f444. ± Comparison against base commit 2ba622f.

♻️ This comment has been updated with latest results.

[github-actions]

Functional Tests - corerp-cloud

32 tests  ±0   31 ✅ ±0   23m 57s ⏱️ + 5m 30s
 2 suites ±0    1 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 3abed10. ± Comparison against base commit b0875a4.

♻️ This comment has been updated with latest results.

[radius-functional-tests]

Radius functional test overview

🔍 Go to test action run

Click here to see the test run details

Name	Value
Repository	radius-project/radius
Commit ref	3abed10
Unique ID	func1c4509e35b
Image tag	pr-func1c4509e35b

• Dapr: 1.14.4
• Azure KeyVault CSI driver: 1.4.2
• Azure Workload identity webhook: 1.3.0
• Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func1c4509e35b
• Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
• applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func1c4509e35b
• dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func1c4509e35b
• controller test image location: ghcr.io/radius-project/dev/controller:pr-func1c4509e35b
• ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func1c4509e35b
• deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

[Copilot]

Pull request overview

Fixes long-running test (LRT) cleanup failures by ensuring functional-test resource teardown happens in a dependency-safe order (apps/resources before environments/recipe packs), and documents the behavior so CI vs LRT cleanup differences are clear.

Changes:

• Introduces validation.ResourcesInDeletionOrder and uses it during cleanup to delete applications first, then app-scoped resources, then environments, then recipe packs (stable within each group).
• Reorders the MySQL portal-link functional test’s declared cleanup resources to align with dependency-ordered teardown.
• Adds unit tests, updates functional-test cleanup documentation, and temporarily skips the released LRT version of the affected test until a fixed release is available.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
test/validation/shared.go	Adds teardown ranking + ResourcesInDeletionOrder helper to enforce dependency-ordered deletions.
test/validation/shared_test.go	Adds table-driven unit coverage for ordering behavior and non-mutation of inputs.
test/rp/rptest.go	Uses ResourcesInDeletionOrder(step.RPResources) during cleanup, making nil RPResources safe and enforcing teardown order.
test/functional-portable/corerp/cloud/resources/radiuscore_azure_mysql_portallink_test.go	Reorders resource declarations so app/db delete precedes environment/recipe pack deletion.
docs/contributing/contributing-code/contributing-code-tests/running-functional-tests.md	Clarifies fast-cleanup behavior and documents dependency-ordered teardown.
.github/workflows/long-running-azure.yaml	Temporarily extends released-suite skip list to include the affected test until a fixed release is cut.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.