Skip to content

Switch DELETE_RADIUS_REF to main once radius PR #12367 merges #47

Description

@sk593

Context

The canvas Delete Deployment button dispatches the delete-application.yml workflow (rad app delete) using delete-workflow templates and the delete-resource composite action introduced in radius-project/radius PR #12367 ("Add custom recipe pack support and delete workflows to Repo Radius").

Those templates + the delete-resource action are not yet on radius-project/radius@main, so we temporarily pin them to the PR's branch.

What to change once #12367 merges

In radius-core/src/workflows/delete.ts:

export const DELETE_RADIUS_REF = "sk593-custom-types-recipe-packs";
  • Change DELETE_RADIUS_REF to point at main (or just re-use the exported RADIUS_REF, which is "main"), and remove the now-unnecessary constant/comment.
  • This ref is used for both:
    1. Fetching the delete-workflow templates (generateDeleteWorkflow in adapters/canvas/src/infra.mjs), and
    2. The {{RADIUS_REF}} the generated delete-azure.yml / delete-aws.yml pin their composite actions to (setup-control-plane, restore-state, delete-resource, teardown).

Verification after the switch

  • generateDeleteWorkflow(env) fetches templates without a 404 at main.
  • Generated provider workflows reference composite actions @main (including delete-resource@main).
  • A newly-created environment commits delete-application.yml + delete-azure.yml, and Delete Deployment dispatches successfully.

References

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions