Conversation
This comment has been minimized.
This comment has been minimized.
ITProKyle
reviewed
Feb 26, 2020
ITProKyle
reviewed
Feb 27, 2020
ITProKyle
reviewed
Feb 27, 2020
Contributor
ITProKyle
left a comment
There was a problem hiding this comment.
I would prefer to stop using runway.hooks and instead have all hooks in runway.cfngin.hooks so they are all grouped together. we can't move anything that already exists there till the next major release since it could be breaking but, i don't think that means we need to continue putting new things in runway.hooks.
ITProKyle
reviewed
Feb 27, 2020
ITProKyle
reviewed
Feb 27, 2020
troyready
reviewed
Feb 28, 2020
troyready
suggested changes
Mar 2, 2020
troyready
reviewed
Mar 2, 2020
troyready
suggested changes
Mar 2, 2020
troyready
reviewed
Mar 3, 2020
troyready
reviewed
Mar 3, 2020
troyready
suggested changes
Mar 4, 2020
troyready
suggested changes
Mar 4, 2020
| object is generated with hard coded values via Runway. | ||
| """ | ||
| # pylint: disable=undefined-variable | ||
| config = {{{DynamicConfig}}} # noqa |
Contributor
There was a problem hiding this comment.
I think it'd be fine to just wrap a substitution regex around the whole line (or nearly the whole line).
troyready
suggested changes
Mar 5, 2020
troyready
suggested changes
Mar 5, 2020
troyready
suggested changes
Mar 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Creates the ability to generate a private static site using Auth@Edge as described here: https://aws.amazon.com/blogs/networking-and-content-delivery/authorizationedge-how-to-use-lambdaedge-and-json-web-tokens-to-enhance-web-application-security/
Why This Is Needed
This has been a frequent request of our development teams to be able to create a single page application behind an authentication interface.
What Changed
Added
StaticSiteBlueprintChanged
StaticSiteBlueprint from using CFN Conditional logic to using pure Python conditional logic. This gives us finer-grained control over how we create our CFN templates while losing the template output consistency. This isn't a problem in and of itself but does require dependency of Runway to generate the templates.Screenshots