[bug-hunter] Retain active import recovery journal#1572
Draft
r3dbars wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep the durable imported-audio journal until the active transcription reaches a terminal state.
User impact
The import journal was deleted as soon as model preparation handed work to the in-memory transcription task. A crash or force-quit during inference could therefore leave the scratch audio with no recovery journal or failed-queue record.
Fix
Evidence and scope
origin/mainat2f8e01ef.maincovers model preparation; this closes the active-import handoff gap.Verification
swift test: 801 tests passed, 13 expected skips, 0 failures.bash run-integration-smoke.sh: passed.bash build.sh --no-open: signed app build and launch smoke passed; launch time 1352 ms against a 3000 ms budget.bash run-tests.sh: 13,046 tests passed, 0 failures.Proof boundary
The deterministic test covers the in-flight crash window, but no manual crash/force-quit or real hardware/audio proof was performed in this run.