[bug-hunter] Preserve stopped dictation audio#1547
Closed
r3dbars wants to merge 8 commits into
Closed
Conversation
Owner
Author
|
Exact-head repair pushed at Fixed the review findings and the follow-on lifecycle issues found during independent review:
Proof:
Keeping this PR as a draft until the real mic -> quit/relaunch -> Finder/Home recovery flow is manually proven. Fresh CI is now running on the repaired head. |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Proof
bash build-deps.sh --forcebash build.sh --no-openTRANSCRIPTED_DISABLE_FILE_LOGGER=1 bash run-tests.sh(13,211 passed)git diff --checkManual boundary
Real microphone capture, app restart, Finder reveal, and Home import were not exercised. Imported recovery WAVs remain until explicitly deleted because the import pipeline has no safe completion callback in this scope.