Skip to content

Add atssimple dac support#849

Open
maxbeer99 wants to merge 6 commits into
qutech:masterfrom
maxbeer99:issues/848_dac_interface_atssimple
Open

Add atssimple dac support#849
maxbeer99 wants to merge 6 commits into
qutech:masterfrom
maxbeer99:issues/848_dac_interface_atssimple

Conversation

@maxbeer99

@maxbeer99 maxbeer99 commented Jun 17, 2024

Copy link
Copy Markdown

Resolves #848

  • add newspiece

@github-actions

github-actions Bot commented Jun 17, 2024

Copy link
Copy Markdown

Test Results

    3 files      3 suites   3m 46s ⏱️
1 196 tests 1 135 ✅  61 💤 0 ❌
3 588 runs  3 405 ✅ 183 💤 0 ❌

Results for commit b33b9e6.

♻️ This comment has been updated with latest results.

@maxbeer99

maxbeer99 commented Jun 17, 2024

Copy link
Copy Markdown
Author

Usage: Jupyter Notebook Example

@shumpohl

Copy link
Copy Markdown
Member

Optimally include the usage example in doc/source/examples

@shumpohl

Copy link
Copy Markdown
Member

Code looks good to me

"import qupulse.hardware\n",
"import qupulse.hardware.awgs\n",
"import qupulse.hardware.awgs.zihdawg\n",
"import qupulse._program\n",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this import required?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, see 1fcf616

@maxbeer99

Copy link
Copy Markdown
Author

Note that input range is not yet used to scale results. This needs to be implemented before merge

@shumpohl

Copy link
Copy Markdown
Member

Shouldn't this be implemented in simpleats itself?

@maxbeer99

Copy link
Copy Markdown
Author

Shouldn't this be implemented in simpleats itself?

Yes, just forgot to pass required args.

@maxbeer99

Copy link
Copy Markdown
Author

Note that here I implemented non-blocking acquisition in atssimple directly. Before merge this should be used in qupulse instead of the ad-hoc implementation.

@maxbeer99

Copy link
Copy Markdown
Author

Note that input range is not yet used to scale results. This needs to be implemented before merge

done

@maxbeer99

Copy link
Copy Markdown
Author

Note that here I implemented non-blocking acquisition in atssimple directly. Before merge this should be used in qupulse instead of the ad-hoc implementation.

done

@maxbeer99

Copy link
Copy Markdown
Author

ready to merge btw

@maxbeer99 maxbeer99 marked this pull request as ready for review August 1, 2024 12:48
@shumpohl shumpohl added this to the Release 1.0 milestone Jan 15, 2025
@Nomos11 Nomos11 mentioned this pull request Aug 19, 2025
@Nomos11

Nomos11 commented Aug 19, 2025

Copy link
Copy Markdown
Collaborator

is this in development / will it be usable / should it be merged / what is the relation to #874 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement dac interface for atssimple

3 participants