Skip to content

Refactor trigger property logic to avoid self.trigger = self.trigger#168

Open
shumpohl wants to merge 1 commit into
mainfrom
simon/mfli_trigger
Open

Refactor trigger property logic to avoid self.trigger = self.trigger#168
shumpohl wants to merge 1 commit into
mainfrom
simon/mfli_trigger

Conversation

@shumpohl

@shumpohl shumpohl commented Dec 4, 2025

Copy link
Copy Markdown
Member

This is not optimal because as the pre-existing TODO states, we should inform the user if we override the settings. But it reduces the abuse of property update logic.

@codecov

codecov Bot commented Dec 4, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 22.12%. Comparing base (6f1694a) to head (3a15433).

Files with missing lines Patch % Lines
src/qumada/instrument/buffers/mfli_buffer.py 38.46% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
- Coverage   22.26%   22.12%   -0.14%     
==========================================
  Files          38       38              
  Lines        4703     4691      -12     
==========================================
- Hits         1047     1038       -9     
+ Misses       3656     3653       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Dec 4, 2025

Copy link
Copy Markdown

Test Results

  4 files  ±0   4 suites  ±0   12s ⏱️ +2s
 25 tests ±0  24 ✅  - 1  0 💤 ±0  1 ❌ +1 
100 runs  ±0  98 ✅  - 2  0 💤 ±0  2 ❌ +2 

For more details on these failures, see this check.

Results for commit 3a15433. ± Comparison against base commit 6f1694a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant