httptransport: fix negotiated error responses#2454
Merged
github-actions[bot] merged 1 commit intoMay 11, 2026
Merged
Conversation
Signed-off-by: immanuwell <pchpr.00@list.ru>
crozzy
force-pushed
the
fix/content-negotiation-error-response
branch
from
0144318 to
f77fca4
Compare
crozzy
approved these changes
May 11, 2026
Collaborator
|
/fast-forward |
Collaborator
|
Thanks @immanuwell for the contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small cleanup for content negotiation error path.
Before this,
pickContentTypewrote415itself, then callers tried to sendapiError. Too late: headers were already committed, so/openapi/v1withAccept: application/xmlgot a415with no JSON content-type. tiny paper cut, but annoying for clients.Repro:
go test ./httptransport -run 'TestDiscovery/Failure' -count=1 -vfails withgot content-type: "", want: "application/json"Validation:
go test ./httptransport -run 'TestDiscovery' -count=1go test ./...Related: #1441, #1523-ish