Skip to content

Support Cirq 1.7 change in exponents that affects rendering of circuit diagrams #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhucka merged 6 commits into from
Jul 6, 2026
+27 −3
Merged

Support Cirq 1.7 change in exponents that affects rendering of circuit diagrams #1397

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e7a2e9f
Support Cirq 1.7 change in exponents in circuit diagrams
mhucka Jul 2, 2026
c999669
Merge branch 'main' into fix-diagram-change
mhucka Jul 2, 2026
57a25c2
Update src/openfermion/circuits/gates/four_qubit_gates.py
mhucka Jul 2, 2026
02305c6
Use numbers.Real instead of list of numerical types
mhucka Jul 6, 2026
001d095
Add test case for exponent types
mhucka Jul 6, 2026
7ee4c30
Format
mhucka Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/openfermion/circuits/gates/four_qubit_gates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,13 @@ def _circuit_diagram_info_(self, args: cirq.CircuitDiagramInfoArgs) -> cirq.Circ
# Split up this string to avoid SyntaxError in Python 3.12.
down_up = r'\/ /' + '\\'
wire_symbols = (up_down, up_down, down_up, down_up)
return cirq.CircuitDiagramInfo(
wire_symbols=wire_symbols, exponent=self._diagram_exponent(args)
)

exponent = self._diagram_exponent(args)
if isinstance(exponent, (int, float, np.integer, np.floating)):

@pavoljuhas pavoljuhas Jul 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional - consider using numbers.Real instead.

@mhucka mhucka Jul 6, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good point.

# Canonicalize rounded exponent into (-1, 1] range (DoubleExcitation has period 2)
exponent = 1.0 - (1.0 - exponent) % 2.0

return cirq.CircuitDiagramInfo(wire_symbols=wire_symbols, exponent=exponent)

def __repr__(self):
if self.exponent == 1:
Expand Down
Loading