feat(sdk): stamp pulled models with their QAIRT version#1179
Draft
RemiliaForever (RemiliaForever) wants to merge 2 commits into
Draft
feat(sdk): stamp pulled models with their QAIRT version#1179RemiliaForever (RemiliaForever) wants to merge 2 commits into
RemiliaForever (RemiliaForever) wants to merge 2 commits into
Conversation
AI Hub's release-assets.json declares, per asset, the QAIRT version its Genie artifacts were exported against (tool_versions.qairt). Parse that field and persist it into each model's geniex.json as QairtVersion at pull time, so a later run can tell whether cached artifacts still match the runtime this build ships — the "stale artifact after a GenieX update" case from #1229. The value is empty for non-AI-Hub / llama.cpp models and omitted from the serialized manifest when empty; legacy manifests without the key still deserialize. Expose it through the FFI so bindings can read it: append qairt_version to geniex_ModelPaths and thread it through the Go and Python model-paths wrappers (FFI surfaces updated in lockstep per CONTRIBUTING §4). Compatibility checking on top of this stamp is left for a follow-up. Signed-off-by: RemiliaForever <remilia@koumakan.cc>
The pinned aihm release version and base URL are owned by the Rust model-manager (sdk/model-manager/crates/core/src/config.rs); the CLI's DefaultAIHubBaseURL / DefaultAIHubVersion constants and the AIHubVersion config field were dead mirrors with no remaining readers. Remove them and the stale viper default. Signed-off-by: RemiliaForever <remilia@koumakan.cc>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Persist, per cached model, the QAIRT version its assets were built for, and expose it through the FFI to the bindings.
release-assets.jsondeclarestool_versions.qairtfor each Genie asset (e.g.2.45.0.260326154327). We now parse that field (previously dropped) and write it into each model'sgeniex.jsonasQairtVersionat pull time.geniex_ModelPaths→ GoModelPaths.QairtVersionand the PythonModelPathsdataclass.Why
Part of #1229. After a
geniex updatebumps the bundled QAIRT, a model pulled under the old runtime may carry incompatible artifacts. Recording the QAIRT version each model was pulled for is the prerequisite for detecting that mismatch. This PR lands the stamp + FFI exposure only; the actual compatibility check / user-facing warning is left for a follow-up.FFI change
sdk/model-manager/include/geniex_model.hgains achar* qairt_versionfield ongeniex_ModelPaths(pure append). Per CONTRIBUTING §4, the Go and Python FFI surfaces are updated in the same PR. Android JNI consumes the header directly and stays layout-compatible on recompile; surfacing the value into its Kotlin bean is out of scope.Tests
tool_versions.qairtfrom a live-shapedrelease-assets.json, serialize/omit theQairtVersionkey, legacy manifest without the key deserializes.ai_hub_pullintegration test to assert the pulledgeniex.jsoncarries the QAIRT version end-to-end.cargo testsuite and the CLIbazelisk test //cli/cmd/geniexpass.Verification
Rebuilt the SDK bridge and confirmed a pulled AI Hub model's
geniex.jsonrecordsQairtVersion, readable via the Go binding'sModelPaths.QairtVersion.