Skip to content

fix(sdk): enable thinking mode on the llama.cpp VLM path #1161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Paul Zhu (vinovo) wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −5
Draft

fix(sdk): enable thinking mode on the llama.cpp VLM path #1161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions sdk/plugins/llama_cpp/src/vlm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,10 +154,7 @@ int32_t LlamaVlm::apply_chat_template(
tmpl_inputs.tools = common_chat_tools_parse_oaicompat(nlohmann::ordered_json::parse(std::string(input->tools)));
}

if (input->enable_thinking) {
GENIEX_LOG_WARN("thinking mode not supported for llama.cpp VLM; ignoring enable_thinking=true");
}
tmpl_inputs.enable_thinking = false;
tmpl_inputs.enable_thinking = input->enable_thinking;
GENIEX_LOG_DEBUG("applying chat template with add_generation_prompt=true, use_jinja={}", tmpl_inputs.use_jinja);

// Apply chat template
Expand Down Expand Up @@ -399,7 +396,7 @@ int32_t LlamaVlm::generate(const geniex_VlmGenerateInput* input, geniex_VlmGener
break;
}

int n = llama_token_to_piece(vocab, token, token_buffer, sizeof(token_buffer) - 1, 0, false);
int n = llama_token_to_piece(vocab, token, token_buffer, sizeof(token_buffer) - 1, 0, true);
if (n < 0) n = 0;
token_buffer[n] = '\0';

Expand Down
Loading