Skip to content

QCLINUX: arm64: dts: qcom: Add rb3gen2 SDE overlay dts#1492

Open
yashgupta2126 wants to merge 1 commit into
qualcomm-linux:tech/overlay/dtfrom
yashgupta2126:tech/overlay/dt
Open

QCLINUX: arm64: dts: qcom: Add rb3gen2 SDE overlay dts#1492
yashgupta2126 wants to merge 1 commit into
qualcomm-linux:tech/overlay/dtfrom
yashgupta2126:tech/overlay/dt

Conversation

@yashgupta2126

Copy link
Copy Markdown

Add SDE (Snapdragon Display Engine) overlay dts for RB3gen2 (QCS6490/Kodiak) board including MDSS, MDP, DSI, eDP nodes and enables its compilation in the Makefile.

Add SDE (Snapdragon Display Engine) overlay dts for RB3gen2
(QCS6490/Kodiak) board including MDSS, MDP, DSI, eDP nodes
and enables its compilation in the Makefile.

Signed-off-by: Yash Gupta <yash.gupta@oss.qualcomm.com>
@qcomlnxci qcomlnxci requested review from a team, knaveen-qc, Tingwei Zhang (quic-tingweiz) and Trilok Soni (trsoni) and removed request for a team July 10, 2026 08:55
@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1492

PR: #1492
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/29081294474

# Error File:Line PR-introduced? Root Cause
1 Missing header file arch/arm64/boot/dts/qcom/glymur-crd-camx.dtso:9 No Pre-existing error: dt-bindings/clock/qcom,glymur-camcc.h header file does not exist in the tree
2 Overlay application failure arch/arm64/boot/dts/qcom/hamoa-evk-camx.dtb No Pre-existing error: Failed to apply hamoa-evk-camx.dtbo overlay (FDT_ERR_NOTFOUND)

Verdict

All errors are pre-existing. This PR does not introduce any build failures. The PR adds new device tree files (kodiak-sde.dtsi, qcs6490-rb3gen2-sde.dtso) that were never compiled during the build due to the build stopping early from unrelated pre-existing errors in glymur-crd-camx.dtso and hamoa-evk-camx.dtbo.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

PR #1492 — validate-patch

PR: #1492

Verdict Issues Detailed Report
N/A 0 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit
Verdict: N/A — click to expand

🔍 Patch Validation

PR: QCLINUX: arm64: dts: qcom: Add rb3gen2 SDE overlay dts (#1492)
Upstream commit: N/A (vendor-only commit)
Verdict: ⏭️ SKIPPED

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: vendor-only commit
Body preserves rationale Clear description of SDE overlay addition
Fixes tag present/correct N/A New feature, not a fix
Authorship preserved Yash Gupta properly attributed
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile Adds overlay build rule for qcs6490-rb3gen2-sde
arch/arm64/boot/dts/qcom/kodiak-sde.dtsi New file: 437 lines of SDE/MDSS/DSI/eDP nodes
arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-sde.dtso New file: 60 lines overlay for RB3gen2 board

Issues

None. This is a vendor-only commit with the correct QCLINUX: prefix indicating no upstream equivalent exists.

Verdict

Validation not applicable. This commit uses the QCLINUX: prefix, which designates vendor-only changes that are not intended for upstream submission. The commit message is clear, authorship is correct, and the change adds RB3gen2 SDE overlay device tree files. No lore.kernel.org link is expected or required for QCLINUX-prefixed commits.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

@qlijarvis

Copy link
Copy Markdown

PR #1492 — checker-log-analyzer

PR: #1492
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/29081294715

Checker Result Summary
Checker Result Summary
checkpatch ⚠️ CI merge failure - checker did not run
dt-binding-check ⚠️ CI merge failure - checker did not run
dtb-check ⚠️ CI merge failure - checker did not run
sparse-check ⚠️ CI merge failure - checker did not run
check-uapi-headers ⚠️ CI merge failure - checker did not run
check-patch-compliance ⚠️ CI merge failure - checker did not run
tag-check N/A Cannot determine - target branch unknown
qcom-next-check N/A Cannot determine - target branch unknown

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1492 - QCLINUX: arm64: dts: qcom: Add rb3gen2 SDE overlay dts
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/29081294715

Checker Result Summary
checkpatch ⚠️ CI merge failure - checker did not run
dt-binding-check ⚠️ CI merge failure - checker did not run
dtb-check ⚠️ CI merge failure - checker did not run
sparse-check ⚠️ CI merge failure - checker did not run
check-uapi-headers ⚠️ CI merge failure - checker did not run
check-patch-compliance ⚠️ CI merge failure - checker did not run
tag-check N/A Cannot determine - target branch unknown
qcom-next-check N/A Cannot determine - target branch unknown

⚠️ CI Infrastructure Failure

Root cause: All checker jobs failed during the merge setup phase with fatal: refusing to merge unrelated histories when attempting to merge PR #1492 into the integration branch.

Failure details:

Merging topic branches...
------------------------------------------
 ** Merging topic branch: topic/tech/overlay/dt
fatal: refusing to merge unrelated histories
Merge failed, manual merge
[...]
Fetching PR #1492 from https://github.com/qualcomm-linux/kernel-topics.git...
From https://github.com/qualcomm-linux/kernel-topics
 * [new ref]                   refs/pull/1492/head -> pr-1492
Merging pr-1492 (no-commit)...
fatal: refusing to merge unrelated histories
Merge failed or conflicts detected. Aborting merge.
fatal: There is no merge to abort (MERGE_HEAD missing).
##[error]Process completed with exit code 3.

Analysis:

This is a CI infrastructure/configuration issue, not a patch quality problem. The error occurs in two places:

  1. Topic branch merge failure: The CI attempts to merge topic/tech/overlay/dt into the baseline integration branch and fails with "unrelated histories"
  2. PR merge failure: The CI then attempts to merge PR QCLINUX: arm64: dts: qcom: Add rb3gen2 SDE overlay dts #1492 and encounters the same error

The "refusing to merge unrelated histories" error indicates that:

  • The PR branch (topic/tech/overlay/dt or PR QCLINUX: arm64: dts: qcom: Add rb3gen2 SDE overlay dts #1492) has a completely different commit history than the baseline branch
  • Git cannot find a common ancestor commit between the two branches
  • This typically happens when a branch was created with --orphan or rebased onto a different root

Why no checkers ran:

All six checker jobs (checkpatch, dt-binding-check, dtb-check, sparse-check, check-uapi-headers, check-patch-compliance) follow the same workflow:

  1. Merge topic branches into baseline
  2. Merge the PR
  3. Run the checker on the merged result

Since step 1 or 2 failed, none of the checkers could execute.

Fix:

This requires investigation of the PR branch history and CI configuration:

  1. Verify the PR branch base:

    git log --oneline --graph pr-1492
    git merge-base <baseline-branch> pr-1492
  2. If the PR branch is truly orphaned or has unrelated history:

    • Rebase the PR onto the correct baseline branch
    • Or use git merge --allow-unrelated-histories (not recommended for production)
  3. If this is a CI configuration issue:

    • Check that the baseline branch reference in the CI workflow is correct
    • Verify that topic/tech/overlay/dt is configured correctly in the integration config
    • Ensure the PR target branch matches the CI baseline branch
  4. Re-trigger CI after fixing the branch history:

    # Close and reopen the PR, or
    # Push an empty commit to trigger a new run
    git commit --allow-empty -m "Trigger CI"
    git push

Reproduce locally:

# Clone the kernel-topics repo
git clone https://github.com/qualcomm-linux/kernel-topics.git
cd kernel-topics

# Fetch the PR
git fetch origin pull/1492/head:pr-1492

# Attempt the merge that CI is trying
git checkout <baseline-branch>  # e.g., qcom-next-staging
git merge pr-1492

# If this fails with "refusing to merge unrelated histories", the issue is confirmed

📋 Patch Content Analysis

Since the checkers didn't run, I performed a manual review of the patch content:

Commit: 1be046d966bcd4abdc66f0336afa75082e30d750
Subject: QCLINUX: arm64: dts: qcom: Add rb3gen2 SDE overlay dts
Author: Yash Gupta yash.gupta@oss.qualcomm.com

Changes:

  • Adds arch/arm64/boot/dts/qcom/kodiak-sde.dtsi (437 lines) - SDE hardware definitions
  • Adds arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-sde.dtso (60 lines) - overlay for RB3gen2
  • Modifies arch/arm64/boot/dts/qcom/Makefile - adds overlay build rules

Observations:

Positive:

  • Proper QCLINUX: prefix for vendor-specific change
  • Signed-off-by present
  • SPDX license identifier present
  • Follows DT overlay pattern (.dtso extension)

⚠️ Potential issues (would be caught by checkers if they ran):

  1. Subject prefix: Uses QCLINUX: which is valid for vendor-only changes, but will always fail check-patch-compliance (known limitation - the checker only accepts FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:)

  2. No upstream link: QCLINUX: commits typically don't have upstream links (vendor-only), but this means check-patch-compliance would fail

  3. DT binding check: The patch adds new DT nodes with compatibles like "qcom,smmu_sde_unsec", "qcom,edp-pll-7nm", "qcom,sde-kms" - these would need corresponding binding documentation or would trigger dt-binding-check warnings

  4. Checkpatch: Would need to verify line lengths, spacing, and other style issues


Verdict

Cannot assess patch quality - CI infrastructure failure prevented all checkers from running.

Required actions:

  1. Immediate: Fix the branch history issue causing "refusing to merge unrelated histories"
  2. After fix: Re-trigger CI to get actual checker results
  3. Expected: Once CI runs, check-patch-compliance will fail due to QCLINUX: prefix (known limitation for vendor-only commits)
  4. Recommended: Verify DT bindings exist for all new compatible strings before merge

Status: ⚠️ CI must be re-run - no quality assessment possible until merge issue is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants