Skip to content

FROMLIST: arm64: dts: qcom: purwa-evk: add DP0/DP1 audio playback support#1447

Open
QTI-Quill wants to merge 32 commits into
qualcomm-linux:tech/all/dt/hamoafrom
QTI-Quill:tech/all/dt/hamoa
Open

FROMLIST: arm64: dts: qcom: purwa-evk: add DP0/DP1 audio playback support#1447
QTI-Quill wants to merge 32 commits into
qualcomm-linux:tech/all/dt/hamoafrom
QTI-Quill:tech/all/dt/hamoa

Conversation

@QTI-Quill

Copy link
Copy Markdown

The purwa-evk DTS currently lacks DAI links for DP0 and DP1, preventing the sound card from exposing these playback paths. Add the missing links to enable audio output on both DP interfaces.

This change follows the same approach as the fix for hamoa-evk.

Link: https://lore.kernel.org/all/20260210024037.3719191-1-le.qi@oss.qualcomm.com/
Link: https://lore.kernel.org/all/20260701063003.3082899-1-le.qi@oss.qualcomm.com/

Jie Gan (jiegan0107) and others added 30 commits July 1, 2026 11:05
… block

The APSS debug block is built with CoreSight devices like ETM,
replicator, funnel and TMC ETF. Add dt nodes for these devices to enable
ETM trace.

Link: https://lore.kernel.org/all/20251218-cpu_cluster_component_pm-v2-12-2335a6ae62a0@oss.qualcomm.com/
Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>
Co-developed-by: Yuanfang Zhang <yuanfang.zhang@oss.qualcomm.com>
Signed-off-by: Yuanfang Zhang <yuanfang.zhang@oss.qualcomm.com>
Embedded Trace Router(ETR) is working as a DDR memory sink to collect
tracing data from source device.

The CTCU serves as the control unit for the ETR device, managing its
behavior to determine how trace data is collected.

Link: https://lore.kernel.org/all/20260204-enable-ctcu-and-etr-v3-2-0bb95c590ae1@oss.qualcomm.com/
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>
Add the CAMCC block for x1e80100. The x1e80100 CAMCC block is an iteration
of previous CAMCC blocks with the exception of having two required
power-domains not just one. And update the compatible for camcc and
videocc nodes on Purwa to match with their respective Purwa (X1P42100)
specific drivers.

https://lore.kernel.org/all/20260409-purwa-videocc-camcc-v4-6-5a8e5f2dd4b2@oss.qualcomm.com/
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>
Add support for SYSTEM_RESET2 vendor-specific resets as
reboot-modes in the psci node.  Describe the resets: "bootloader"
will cause device to reboot and stop in the bootloader's fastboot
mode.  "edl" will cause device to reboot into "emergency download
mode", which permits loading images via the Firehose protocol.

Signed-off-by: Xin Liu <xin.liu@oss.qualcomm.com>
Link: https://lore.kernel.org/all/20260226054113.4156874-1-xin.liu@oss.qualcomm.com/
Add in two CCI buses.

One bus has two CCI bus master pinouts:
cci_i2c_sda0 = gpio101
cci_i2c_scl0 = gpio102

cci_i2c_sda1 = gpio103
cci_i2c_scl1 = gpio104

The second bus has two CCI bus master pinouts:
cci_i2c_sda2 = gpio105
cci_i2c_scl2 = gpio106

aon_cci_i2c_sda3 = gpio235
aon_cci_i2c_scl3 = gpio236

Link: https://lore.kernel.org/all/20260326-x1e-camss-csi2-phy-dtsi-v3-2-1d5a9306116a@linaro.org/
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Add dtsi to describe the xe180100 CAMSS block

4 x CSIPHY
3 x TPG
2 x CSID
2 x CSID Lite
2 x IFE
2 x IFE Lite

Link: https://lore.kernel.org/all/20260326-x1e-camss-csi2-phy-dtsi-v3-3-1d5a9306116a@linaro.org/
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
…gulators

Add pmic,id = m rpmh to regulator definitions. This regulator set provides
vreg_l3m_1p8 the regulator for the ov08x40 RGB sensor on the CRD.

Link: https://lore.kernel.org/all/20260326-x1e-camss-csi2-phy-dtsi-v3-4-1d5a9306116a@linaro.org/
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
…SIPHY4

Define ov08x40 on cci1_i2c1. The RGB sensor appears on the AON CCI pins
connected to CSIPHY4 in four lane mode.

Link: https://lore.kernel.org/all/20260326-x1e-camss-csi2-phy-dtsi-v3-5-1d5a9306116a@linaro.org/
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
…h voltage levels for IR and RGB camera

Add the PM8010 PMIC providing the following voltage rails:

vreg_l1m_r @ 1v2 IR sensor
vreg_l2m_r @ 1v2 RGB sensor
vreg_l3m_r @ 1v8 IR sensor
vreg_l4m_r @ 1v8 RGB sensor
vreg_l5m_r @ 2v8 IR sensor
vreg_l7m_r @ 2v8 RGB sensor

Link: https://lore.kernel.org/all/20260326-x1e-camss-csi2-phy-dtsi-v3-6-1d5a9306116a@linaro.org/
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
…on CSIPHY4

Switch on the ov02c10 RGB sensor on CSIPHY4.

Link: https://lore.kernel.org/all/20260326-x1e-camss-csi2-phy-dtsi-v3-7-1d5a9306116a@linaro.org/
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
…amera PMIC with voltage levels for IR and RGB camera

Add voltage regulators-8 for Camera on slim7x including:

- vreg_l1m_1p2
- vreg_l3m_1p8

Link: https://lore.kernel.org/all/20260326-x1e-camss-csi2-phy-dtsi-v3-8-1d5a9306116a@linaro.org/
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
…voltage regulator for RGB camera

Some sleuthing work by Aleksandrs Vinarskis in the bowels of the ACPI
tables for this part shows we need l7b_2p8 for the avdd supply.

Link: https://lore.kernel.org/all/20260326-x1e-camss-csi2-phy-dtsi-v3-9-1d5a9306116a@linaro.org/
Suggested-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
…RGB sensor on CSIPHY4

Add in the RGB sensor on CSIPHY4.

Link: https://lore.kernel.org/all/20260326-x1e-camss-csi2-phy-dtsi-v3-10-1d5a9306116a@linaro.org/
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
…CAMSS RGB sensor

Inspiron14 has a ov02e10 sensor on CSIPHY4. Enable the list of dependencies
now.

Link: https://lore.kernel.org/all/20260326-x1e-camss-csi2-phy-dtsi-v3-11-1d5a9306116a@linaro.org/
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Add pm8010 L4M regulator which is used by Camera I2C pull-up.

Signed-off-by: Tingguo Cheng <tingguo.cheng@oss.qualcomm.com>
Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
Link: https://lore.kernel.org/all/20260227-hamoa_evk-v1-1-36f895a24d8f@oss.qualcomm.com/
Enable IMX577 via CCI on Hamoa EVK Core Kit.

The Hamoa EVK board does not include a camera sensor
by default, this DTSO has enabled the Arducam 12.3MP
IMX577 Mini Camera Module on the CSI-1 interface.

Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
Link: https://lore.kernel.org/all/20260227-hamoa_evk-v1-2-36f895a24d8f@oss.qualcomm.com/
…vice

Interconnect from SCM device are optional and were added to get
additional performance benefit. These nodes however delays the
SCM firmware device probe due to dependency on interconnect and
results in NULL pointer dereference for the users of SCM device
driver APIs, such as PDC driver.

Remove them from the scm device to unblock the user.

Link: https://lore.kernel.org/r/20260312-hamoa_pdc-v1-1-760c8593ce50@oss.qualcomm.com
Signed-off-by: Maulik Shah <maulik.shah@oss.qualcomm.com>
Signed-off-by: Sneh Mankad <sneh.mankad@oss.qualcomm.com>
Add deepest idle state along with pdc config reg to make GPIO IRQs work
as wakeup capable interrupts in deepest idle state.

Add QMP handle to allow PDC device to place a SoC level low power mode
restriction.

Link: https://lore.kernel.org/r/20260312-hamoa_pdc-v1-4-760c8593ce50@oss.qualcomm.com
Signed-off-by: Maulik Shah <maulik.shah@oss.qualcomm.com>
Signed-off-by: Sneh Mankad <sneh.mankad@oss.qualcomm.com>
Purwa shares the Hamoa (X1E80100) PDC device, but the hardware register
bug addressed in commit e9a48ea ("irqchip/qcom-pdc: Workaround
hardware register bug on X1E80100") is already fixed in Purwa silicon.

Hamoa compatible forces the software workaround. Use the Purwa specific
compatible string for the PDC node to remove the workaround from Purwa.

Fixes: f08edb5 ("arm64: dts: qcom: Add X1P42100 SoC and CRD")
Link: https://lore.kernel.org/r/20251231-purwa_pdc-v1-2-2b4979dd88ad@oss.qualcomm.com
Signed-off-by: Maulik Shah <maulik.shah@oss.qualcomm.com>
Signed-off-by: Sneh Mankad <sneh.mankad@oss.qualcomm.com>
Purwa's GPU does not support SID 1, which is typically used for
LPAC-related traffic. Remove SID 1 from the GPU node's iommus property to
accurately describe the hardware. This fixes the splat below, seen with
some versions of Gunyah hypervisor:

  Internal error: synchronous external abort: 0000000096000010 [qualcomm-linux#1]  SMP
  CPU: 0 UID: 0 PID: 80 Comm: kworker/u33:2 Tainted: G   M
  Tainted: [M]=MACHINE_CHECK
  Hardware name: Qualcomm Technologies, Inc. Purwa IoT EVK (DT)
  Workqueue: events_unbound deferred_probe_work_func
  pstate: 21400005 (nzCv daif +PAN -UAO -TCO +DIT -SSBS BTYPE=--)
  pc : arm_smmu_write_s2cr+0x9c/0xbc
  lr : arm_smmu_master_install_s2crs+0x78/0xa4
  sp : ffff80008039b570
  x29: ffff80008039b570 x28: 0000000000000000 x27: ffffaddd62f1ab78
  x26: ffff00080a4ff280 x25: 0000000000000018 x24: ffff00080b896480
  x23: ffff00080ba9b7a0 x22: ffff00080bb05160 x21: 0000000000000000
  x20: 0000000000000000 x19: 0000000000000001 x18: 00000000ffffffff
  x17: 0000000000000000 x16: 0000000000000000 x15: ffff80008039b1d0
  x14: ffff80010039b37d x13: 00746c7561662d74 x12: 0000000000000000
  x11: ffff00080b7fbd98 x10: ffffffffffffffc0 x9 : ffffffffffffffff
  x8 : 0000000000000228 x7 : 0000000000000e87 x6 : 0000000000000000
  x5 : 0000000000000000 x4 : ffff00080a4ff280 x3 : 0000000000000000
  x2 : ffff800082a40c04 x1 : 0000000000000000 x0 : ffff800082a40000
  Call trace:
   arm_smmu_write_s2cr+0x9c/0xbc (P)
   arm_smmu_master_install_s2crs+0x78/0xa4
   arm_smmu_attach_dev+0xb0/0x1d8
   __iommu_device_set_domain+0x84/0x11c
   __iommu_group_set_domain_internal+0x60/0x120
   __iommu_attach_group+0x88/0x9c
   iommu_attach_device+0x6c/0xa0
   msm_iommu_new.part.0+0x84/0xe4 [msm]
   msm_iommu_gpu_new+0x3c/0x104 [msm]
   adreno_iommu_create_vm+0x24/0xc8 [msm]
   a6xx_create_vm+0x48/0x78 [msm]
   msm_gpu_init+0x2d8/0x508 [msm]
   adreno_gpu_init+0x208/0x324 [msm]
   a6xx_gpu_init+0x604/0x8cc [msm]
   adreno_bind+0xb4/0x124 [msm]
   component_bind_all+0x114/0x23c
   msm_drm_init+0x1b0/0x1ec [msm]
   msm_drm_bind+0x30/0x3c [msm]
   try_to_bring_up_aggregate_device+0x164/0x1d0
   __component_add+0xa4/0x16c
   component_add+0x14/0x20
   msm_dp_display_probe_tail+0x4c/0xac [msm]
   msm_dp_auxbus_done_probe+0x14/0x20 [msm]
   dp_aux_ep_probe+0x4c/0xf4 [drm_dp_aux_bus]
   really_probe+0xbc/0x29c
   __driver_probe_device+0x78/0x12c
   driver_probe_device+0x3c/0x15c
   __device_attach_driver+0xb8/0x134
   bus_for_each_drv+0x88/0xe8
   __device_attach+0xa0/0x190
   device_initial_probe+0x50/0x54
   bus_probe_device+0x38/0xa4
   deferred_probe_work_func+0x88/0xc0
   process_one_work+0x148/0x28c
   worker_thread+0x2cc/0x3d4
   kthread+0x12c/0x204
   ret_from_fork+0x10/0x20
  ---[ end trace 0000000000000000 ]---

Fixes: 1aa0b4e ("arm64: dts: qcom: x1p42100: Add GPU support")
Signed-off-by: Akhil P Oommen <akhilpo@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260410-purwa-gpu-dt-fix-v1-1-4637892156cf@oss.qualcomm.com
Add node for the X1P42100 camera subsystem.

Link: https://lore.kernel.org/all/20260410-purwa_camss-v1-3-eedcf6d9d8ee@oss.qualcomm.com/
Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
enable camss node for purwa iot evk board camss tpg support.

Link: https://lore.kernel.org/all/20260410-purwa_camss-v1-4-eedcf6d9d8ee@oss.qualcomm.com/
Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
Add embedded controller node for Hamoa/Purwa CRDs which adds fan control,
temperature sensors, access to EC internal state changes and suspend
entry/exit notifications to the EC.

Link: https://lore.kernel.org/lkml/20260427-add-driver-for-ec-v8-4-702f74e495f7@oss.qualcomm.com/
Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
Co-developed-by: Anvesh Jain P <anvesh.p@oss.qualcomm.com>
Signed-off-by: Anvesh Jain P <anvesh.p@oss.qualcomm.com>
Add embedded controller node for Hamoa IOT EVK boards which adds fan
control, temperature sensors, access to EC internal state changes and
suspend entry/exit notifications to the EC.

Link: https://lore.kernel.org/lkml/20260427-add-driver-for-ec-v8-5-702f74e495f7@oss.qualcomm.com/
Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>
Tested-by: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>
Co-developed-by: Anvesh Jain P <anvesh.p@oss.qualcomm.com>
Signed-off-by: Anvesh Jain P <anvesh.p@oss.qualcomm.com>
… points

The Iris block on X1P differs from SM8550/X1E in its clock configuration
and requires a dedicated OPP table. The node inherited from the X1E cannot
be reused directly, and the fallback compatible "qcom,sm8550-iris" cannot
be applied.

Override the inherited clocks, clock-names, and operating points, and
replaces them with the X1P42100-specific definitions. A new OPP table
is provided to support the correct performance levels on this platform.

Link: https://lore.kernel.org/linux-arm-msm/20260429-enable_iris_on_purwa-v5-4-438fa96da248@oss.qualcomm.com/
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Wangao Wang <wangao.wang@oss.qualcomm.com>
Enable video nodes on the purwa-iot-som board.

Link: https://lore.kernel.org/linux-arm-msm/20260429-enable_iris_on_purwa-v5-5-438fa96da248@oss.qualcomm.com/
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Reviewed-by: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
Signed-off-by: Wangao Wang <wangao.wang@oss.qualcomm.com>
Switch the iris video codec node in hamoa from the legacy 'iommus'
property to 'iommu-map', using IRIS_NON_PIXEL_VCODEC and IRIS_PIXEL
function IDs to identify the non-pixel and pixel context bank SMMU
stream mappings respectively.

Signed-off-by: Vishnu Reddy <busanna.reddy@oss.qualcomm.com>
Signed-off-by: Vikash Garodia <vikash.garodia@oss.qualcomm.com>
Signed-off-by: Gourav Kumar <gouravk@qti.qualcomm.com>
On Qualcomm Hamoa SoCs, the memlat governor and the mechanism
to control the LLCC and DDR/DDR_QOS is hosted on the CPU Control
Processor (CPUCP). Add the vendor protocol node to the existing
SCMI transport to enable QCOM SCMI Generic Extension protocol on
Hamoa SoCs.

Link: https://lore.kernel.org/lkml/20260507062237.78051-9-sibi.sankar@oss.qualcomm.com/
Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
Purwa IOT boards support a different thermal junction temperature
specification compared to the base Purwa platform due to package
level differences.

Update the passive trip thresholds to 105°C to align with the higher
temperature specification.

Signed-off-by: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260416-purwa_high_tj-v1-1-b538f98d42da@oss.qualcomm.com
Add video firmware node to enable video kvm on the hamoa.

Signed-off-by: Renjiang Han <renjiang@qti.qualcomm.com>
Jie Gan (jiegan0107) and others added 2 commits July 1, 2026 11:05
…devices

Add label properties to TPDM and CTI nodes in the hamoa device tree to
provide human-readable identifiers for each CoreSight device. These
labels allow userspace tools and the CoreSight framework to identify
devices by name rather than by base address.

Link: https://lore.kernel.org/linux-arm-msm/20260414-add-label-to-coresight-device-v2-7-5017d07358f2@oss.qualcomm.com/
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>
…port

The purwa-evk DTS currently lacks DAI links for DP0 and DP1, preventing
the sound card from exposing these playback paths. Add the missing links
to enable audio output on both DP interfaces.

This change follows the same approach as the fix for hamoa-evk.

Link: https://lore.kernel.org/all/20260210024037.3719191-1-le.qi@oss.qualcomm.com/
Link: https://lore.kernel.org/all/20260701063003.3082899-1-le.qi@oss.qualcomm.com/
Signed-off-by: Le Qi <le.qi@oss.qualcomm.com>
@qcomlnxci qcomlnxci requested review from a team, aiquny, Amit Kucheria (idlethread) and Tingwei Zhang (quic-tingweiz) and removed request for a team July 1, 2026 07:15
@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1447

PR: #1447
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28500368681

# Error File:Line PR-introduced? Root Cause
1 Merge conflict (add/add) Documentation/devicetree/bindings/cpufreq/qcom,shikra-epss.yaml No Pre-existing conflict between baseline (qcom-next) and target branch (tech/all/dt/hamoa)
2 Merge conflict (content) Documentation/devicetree/bindings/crypto/qcom,prng.yaml No Pre-existing conflict between baseline and target branch
3 Merge conflict (content) Documentation/devicetree/bindings/crypto/qcom-qce.yaml No Pre-existing conflict between baseline and target branch
4 Merge conflict (content) Documentation/devicetree/bindings/display/msm/gpu.yaml No Pre-existing conflict between baseline and target branch
5 Merge conflict (add/add) Documentation/devicetree/bindings/interconnect/qcom,shikra.yaml No Pre-existing conflict between baseline and target branch
6-101 96 additional merge conflicts Various files (DT bindings, drivers, includes) No Pre-existing conflicts between baseline and target branch

Verdict

All 101 merge conflicts are pre-existing integration issues between the baseline branch (qcom-next) and the target branch (tech/all/dt/hamoa). None are introduced by this PR. The PR file (arch/arm64/boot/dts/qcom/purwa-iot-evk.dts) was successfully auto-merged without conflicts.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1447

PR: #1447
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28500368681

# Error File:Line PR-introduced? Root Cause
1 Merge conflict during automerge Documentation/devicetree/bindings/cpufreq/qcom,shikra-epss.yaml No Pre-existing integration conflict between baseline (qcom-next) and topic branch (tech/all/dt/hamoa). Both branches independently created the same file.

Verdict

This is not a compilation error. The build failed during the pre-merge integration phase due to a merge conflict in a file unrelated to this PR. The PR only modifies arch/arm64/boot/dts/qcom/purwa-iot-evk.dts and does not introduce any compilation errors.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

PR #1447 — validate-patch

PR: #1447

Verdict Issues Detailed Report
⚠️ 3 Full report

Final Summary

  1. Lore link present: Yes - two links provided (first is reference hamoa-evk patch, second should be purwa-evk submission)
  2. Lore link matches PR commits: Cannot verify - network restrictions prevent fetching purwa-evk lore patch for comparison
  3. Upstream patch status: In review - FROMLIST prefix indicates posted to mailing list but not yet merged; cannot verify posting due to network restrictions
  4. PR present in qcom-next: No - not found in qcom-next branch; this is a new submission
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1447 - arm64: dts: qcom: purwa-evk: add DP0/DP1 audio playback support
Upstream commit: https://lore.kernel.org/all/20260701063003.3082899-1-le.qi@oss.qualcomm.com/ (cannot verify - network restricted)
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream ⚠️ Uses lowercase "add" vs upstream hamoa used "Add"; otherwise follows pattern
Body preserves rationale Clear rationale explaining missing DAI links; includes reference to hamoa-evk
Fixes tag present/correct N/A Not a fix; new feature addition
Authorship preserved Le Qi le.qi@oss.qualcomm.com - same author as hamoa-evk patch
Backport note (if applicable) N/A FROMLIST prefix indicates pending upstream submission

Diff

File Status Notes
arch/arm64/boot/dts/qcom/purwa-iot-evk.dts Identical structure to upstream hamoa-evk patch; adds dp0-dai-link and dp1-dai-link nodes

Issues

  • Subject capitalization: Uses lowercase "add" instead of "Add" (upstream hamoa commit used "Add DP0/DP1 audio playback support")
  • First lore link: Points to hamoa-evk patch (20260210024037.3719191-1) as reference, not the actual purwa-evk upstream submission
  • Extra context line: "This change follows the same approach as the fix for hamoa-evk." is helpful but not typical for upstream commit messages (usually omitted in favor of concise rationale)
  • Cannot verify upstream status: Network restrictions prevent fetching second lore link (20260701063003.3082899-1) to confirm patch was actually posted upstream

Verdict

Merge with minor subject capitalization fix recommended. Diff is correct and follows established hamoa-evk pattern. Commit message is clear but has minor style inconsistency.

Final Summary

  1. Lore link present: Yes - two links provided (first is reference hamoa-evk patch, second should be purwa-evk submission)
  2. Lore link matches PR commits: Cannot verify - network restrictions prevent fetching purwa-evk lore patch for comparison
  3. Upstream patch status: In review - FROMLIST prefix indicates posted to mailing list but not yet merged; cannot verify posting due to network restrictions
  4. PR present in qcom-next: No - not found in qcom-next branch; this is a new submission

@qlijarvis

Copy link
Copy Markdown

PR #1447 — checker-log-analyzer

PR: #1447
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28500368314

Checker Result Summary
Checker Result Summary
checkpatch ⏭️ CI infrastructure failure - no checker execution
dt-binding-check ⏭️ CI infrastructure failure - no checker execution
dtb-check ⏭️ CI infrastructure failure - no checker execution
sparse-check ⏭️ CI infrastructure failure - no checker execution
check-uapi-headers ⏭️ CI infrastructure failure - no checker execution
check-patch-compliance ⏭️ CI infrastructure failure - no checker execution
tag-check N/A Not executed due to infrastructure failure
qcom-next-check FROMLIST: prefix present

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1447 - FROMLIST: arm64: dts: qcom: purwa-evk: add DP0/DP1 audio playback support
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28500368314

Checker Result Summary
checkpatch ⏭️ CI infrastructure failure - no checker execution
dt-binding-check ⏭️ CI infrastructure failure - no checker execution
dtb-check ⏭️ CI infrastructure failure - no checker execution
sparse-check ⏭️ CI infrastructure failure - no checker execution
check-uapi-headers ⏭️ CI infrastructure failure - no checker execution
check-patch-compliance ⏭️ CI infrastructure failure - no checker execution
tag-check N/A Not executed due to infrastructure failure
qcom-next-check FROMLIST: prefix present

❌ CI Infrastructure Failure (All Checkers)

Root cause: Git merge failure during CI setup phase - "fatal: refusing to merge unrelated histories"

Failure details:

2026-07-01T07:32:11.2698739Z  ** Merging topic branch: topic/tech/all/dt/hamoa
2026-07-01T07:32:29.6802541Z fatal: refusing to merge unrelated histories
2026-07-01T07:32:29.7869160Z Merge failed, manual merge
...
2026-07-01T07:32:30.7966672Z Merging pr-1447 (no-commit)...
2026-07-01T07:32:50.6539218Z fatal: refusing to merge unrelated histories
2026-07-01T07:32:50.7638166Z Merge failed or conflicts detected. Aborting merge.

The CI workflow failed during the repository setup phase before any actual code quality checks could run. The workflow attempts to:

  1. Create an integration branch based on baseline tag 19b282f417584cfe14ce6a262122c51553d026ec
  2. Merge the base branch tech/all/dt/hamoa into the integration branch
  3. Merge PR FROMLIST: arm64: dts: qcom: purwa-evk: add DP0/DP1 audio playback support #1447 on top

Both merge operations failed with "refusing to merge unrelated histories", indicating the base branch and the baseline tag do not share a common git history. This is a CI configuration or repository structure issue, not a problem with the PR code itself.

Fix:

This is a CI infrastructure issue that requires one of the following actions:

  1. Repository maintainer action: Verify that the base branch tech/all/dt/hamoa is properly rebased on or descended from the baseline tag used by the CI system
  2. CI configuration fix: Update the CI workflow to use --allow-unrelated-histories flag if the branch structure intentionally has separate histories
  3. Branch structure fix: Ensure the topic branch tech/all/dt/hamoa shares git history with the mainline kernel baseline

PR author action: The PR code itself appears valid (adds DP0/DP1 DAI links to purwa-iot-evk.dts with proper FROMLIST: prefix and lore links). Request that repository maintainers:

  • Re-trigger the CI after fixing the base branch history issue, OR
  • Manually review and merge the PR if the code changes are acceptable

Reproduce locally:
This cannot be reproduced locally as it's a CI infrastructure issue. However, you can verify the PR code quality manually:

# Clone the repo and checkout the PR
git fetch origin pull/1447/head:pr-1447
git checkout pr-1447

# Run checkpatch on the commit
./scripts/checkpatch.pl -g HEAD

# Verify DT bindings (if dt-schema is installed)
make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/sound/
make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/sound/

Verdict

CI infrastructure failure prevented all code quality checks from executing. The PR cannot be evaluated for code quality issues until the base branch history conflict is resolved. The PR code itself (adding DP0/DP1 audio DAI links) appears straightforward and follows proper FROMLIST conventions with upstream lore links.

Recommended action: Repository maintainers should fix the branch history issue and re-run the CI, or manually review the simple devicetree addition if the changes are acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.