usb: typec: ucsi: ucsi_glink: Prevent suspend during UCSI notification handling#1445
usb: typec: ucsi: ucsi_glink: Prevent suspend during UCSI notification handling#1445jprakash-qc wants to merge 1 commit into
Conversation
🔨 Build Failure Analysis — PR #1445PR: #1445
VerdictThis is not a compilation failure. The build failed during the automerge phase when attempting to merge the PR branch with the baseline. The PR changes themselves are syntactically valid and would not cause compilation errors. The failure is due to pre-existing merge conflicts between the topic branch and the integration baseline, unrelated to the PR's code changes. 📎 Detailed analysis: Full report |
🔨 Build Failure Analysis — PR #1445PR: #1445
VerdictNo compilation errors found. The build failed during the pre-compilation automerge phase due to 102 merge conflicts in unrelated files. The PR changes to 📎 Detailed analysis: Full report |
PR #1445 — validate-patchPR: #1445
Final Summary
|
PR #1445 — checker-log-analyzerPR: #1445
Detailed report: Full report
|
e354b44 to
c5c7baa
Compare
🔨 Build Failure Analysis — PR #1445PR: #1445
VerdictThe build failed during the merge/integration phase before compilation began. The PR changes themselves do not introduce any compilation errors. The failure is caused by pre-existing merge conflicts between the baseline branch and the topic branch that are unrelated to this PR's code changes. 📎 Detailed analysis: Full report |
🔨 Build Failure Analysis — PR #1445PR: #1445
VerdictNo compilation errors were introduced by this PR. The build failed during the merge phase due to 106 pre-existing merge conflicts between the base branch ( 📎 Detailed analysis: Full report |
PR #1445 — validate-patchPR: #1445
Final Summary
|
PR #1445 — checker-log-analyzerPR: #1445
Detailed report: Full report
|
c5c7baa to
5087802
Compare
🔨 Build Failure Analysis — PR #1445PR: #1445
VerdictThis PR introduces 0 build errors. The build failure is caused by 107 pre-existing merge conflicts during the automerge integration phase. The file modified by this PR ( 📎 Detailed analysis: Full report |
🔨 Build Failure Analysis — PR #1445PR: #1445
VerdictThis is a pre-existing integration/merge conflict issue. The PR introduces zero compilation errors. The failure occurred during the git merge phase before any compilation of the PR's changes. 📎 Detailed analysis: Full report |
PR #1445 — validate-patchPR: #1445
Final Summary
|
PR #1445 — checker-log-analyzerPR: #1445
Detailed report: Full report
|
5087802 to
ea998e1
Compare
PR #1445 — validate-patchPR: #1445
Final Summary
|
PR #1445 — checker-log-analyzerPR: #1445
Detailed report: Full report
|
…otification handling
When the system is suspended and a UCSI event arrives (such as USB plug-in),
the GLINK interrupt (with IRQF_NO_SUSPEND flag) fires and it eventually calls
the pmic_glink_ucsi_callback(), which schedules notify_work to handle the
connector change. However, since no wakeup source is held, the system can
re-enter suspend soon after the interrupt handler returns, before notify_work
has completed running, and the USB plug-in event would not be handled.
There was an earlier attempt to address this at the GLINK driver level, by
making the GLINK interrupt wakeup-capable, ("rpmsg: glink: Make glink smem
interrupt wakeup capable") [1], but upstream reviewers suggested a
different approach, preferring wakeup logic to be handled in the client driver.
To avoid losing UCSI notifications in this way, register ucsi_glink
as a wakeup-capable device in the probe, and call pm_wakeup_ws_event()
with hard=true before scheduling notify_work. The hard wakeup aborts any
in-progress suspend, and the timed wakeup source keeps the system
awake long enough for the notify_work call to run.
[1] https://lore.kernel.org/all/20240603073648.3475123-1-quic_deesin@quicinc.com/
Link: https://lore.kernel.org/all/20260710-ucsi_glink_wakeup-v1-1-7d97ea628d92@oss.qualcomm.com/
Signed-off-by: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>
ea998e1 to
1adb9a7
Compare
PR #1445 — validate-patchPR: #1445
Final Summary
|
PR #1445 — checker-log-analyzerPR: #1445
Detailed report: Full report
|
No description provided.