FROMLIST: gpio: Add fwnode_gpiod_get() helper

[ziyuezhang-123]

[PATCH v10 1/2] gpio: Add fwnode_gpiod_get() helper

Add fwnode_gpiod_get() as a convenience wrapper around
fwnode_gpiod_get_index() for the common case where only the
first GPIO is required.

This mirrors existing gpiod_get() and devm_gpiod_get() helpers
and avoids open-coding index 0 at call sites.

Acked-by: Manivannan Sadhasivam mani@kernel.org
Reviewed-by: Linus Walleij linusw@kernel.org
Acked-by: Bartosz Golaszewski bartosz.golaszewski@oss.qualcomm.com

Link: https://lore.kernel.org/all/20260511-wakeirq_support-v10-1-c10af9c9eb8c@oss.qualcomm.com/

CRs-Fixed: 4542930

[qswat-orbit-external]

Merge Check Failed: No Component Found

Configuration Error: No component found for branch 'tech/bus/pci/all'.

There is no component associated with the provided branch in Polaris. Please verify the branch configuration.

Branch: tech/bus/pci/all

[qswat-orbit-external]

Merge Check Failed: No Component Found

Configuration Error: No component found for branch 'tech/bus/pci/all'.

There is no component associated with the provided branch in Polaris. Please verify the branch configuration.

Branch: tech/bus/pci/all

[qswat-orbit-external]

Merge Check Failed: No Component Found

Configuration Error: No component found for branch 'tech/bus/pci/all'.

There is no component associated with the provided branch in Polaris. Please verify the branch configuration.

Branch: tech/bus/pci/all

[qlijarvis]

🔨 Build Failure Analysis — PR #1442

PR: #1442
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28778824236

#	Error	File:Line	PR-introduced?	Root Cause
1	Merge conflict (content)	drivers/pci/pci.c	Yes	PR adds platform_pci_configure_wake() and platform_pci_remove_wake() functions; base branch has conflicting changes in the same file
2	Merge conflict (content)	include/linux/pci.h	Yes	PR adds struct gpio_desc *wake field to struct pci_dev; base branch has conflicting changes in the same structure
3	Merge conflict (content)	Multiple files (98 total)	No	Pre-existing conflicts in base branch unrelated to PR changes (DT bindings, drivers, arch files)

Verdict

2 of 100+ merge conflicts are directly introduced by this PR's changes to PCI subsystem files; 98+ conflicts are pre-existing integration issues in the base branch unrelated to the PR.

Note: This is NOT a compilation failure. The build failed during the automerge/integration phase before compilation could begin. The PR code itself contains no compilation errors.

📎 Detailed analysis: Full report

[qlijarvis]

🔨 Build Failure Analysis — PR #1442

PR: #1442
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28778824236

#	Error	File:Line	PR-introduced?	Root Cause
1	Merge conflict (content)	drivers/pci/pci.c	Yes	PR adds platform_pci_configure_wake() and platform_pci_remove_wake() functions that conflict with other changes in the integration branch
2	Merge conflict (content)	include/linux/pci.h	Yes	PR adds struct gpio_desc *wake field to struct pci_dev that conflicts with other structural changes in the integration branch

Verdict

Both failures are integration conflicts introduced by this PR's changes to the PCI subsystem. These are not compilation errors but merge conflicts that must be resolved before the build can proceed.

📎 Detailed analysis: Full report

[qlijarvis]

PR #1442 — validate-patch

PR: #1442

Verdict	Issues	Detailed Report
❌	0	Full report

Final Summary

1. Lore link present: Yes — both commits have valid lore.kernel.org Link: tags
2. Lore link matches PR commits: Cannot verify — network access restricted; however, commit 1 is empty (zero diff) which is almost certainly incorrect
3. Upstream patch status: Unknown — cannot fetch lore threads or search mainline due to network restrictions; review tags suggest maintainer approval
4. PR present in qcom-next: No — neither commit found in origin/qcom-next

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1442
Upstream commits:

• Commit 1: https://lore.kernel.org/r/20260511-wakeirq_support-v10-1-c10af9c9eb8c@oss.qualcomm.com
• Commit 2: https://lore.kernel.org/r/20260511-wakeirq_support-v10-2-c10af9c9eb8c@oss.qualcomm.com
  Verdict: ❌ FAIL

---

Commit 1: FROMLIST: gpio: Add fwnode_gpiod_get() helper

Commit Message

Check	Status	Note
Subject matches upstream	⏭️ Skipped	Cannot verify — network restricted
Body preserves rationale	✅ PASS	Rationale present and clear
Fixes tag present/correct	N/A	No Fixes tag expected
Authorship preserved	✅ PASS	Original author (Krishna Chaitanya Chundru) present in Signed-off-by; submitter (Ziyue Zhang) in From: — correct for FROMLIST
Backport note	N/A	Not a backport
Link tag present	✅ PASS	Link: https://lore.kernel.org/r/20260511-wakeirq_support-v10-1-c10af9c9eb8c@oss.qualcomm.com

Diff

File	Status	Notes
(none)	❌ FAIL	Commit has NO diff content — empty commit

Issues

1. Critical: Empty commit — Commit 1 claims to add fwnode_gpiod_get() helper in the gpio subsystem, but contains zero diff hunks. The function is referenced in commit 2 (line 163: gpio = fwnode_gpiod_get(...)), indicating a dependency, but the implementation is missing from this PR.

2. Missing implementation — The commit message describes adding a wrapper function, but no code changes are present. This will cause a build failure when commit 2 is applied, as it calls an undefined function.

---

Commit 2: FROMLIST: PCI: Add support for PCIe WAKE# interrupt

Commit Message

Check	Status	Note
Subject matches upstream	⏭️ Skipped	Cannot verify — network restricted
Body preserves rationale	✅ PASS	Detailed rationale with PCIe spec references
Fixes tag present/correct	N/A	No Fixes tag expected (new feature)
Authorship preserved	✅ PASS	Author (Krishna Chaitanya Chundru) matches From: and Signed-off-by
Backport note	N/A	Not a backport
Link tag present	✅ PASS	Link: https://lore.kernel.org/r/20260511-wakeirq_support-v10-2-c10af9c9eb8c@oss.qualcomm.com

Diff

File	Status	Notes
drivers/pci/of.c	⚠️ REVIEW	Adds pci_configure_of_wake_gpio() — calls fwnode_gpiod_get() which is missing from commit 1
drivers/pci/pci.c	✅ PASS	Adds platform wrapper functions
drivers/pci/pci.h	✅ PASS	Adds function declarations
drivers/pci/probe.c	✅ PASS	Calls platform_pci_configure_wake() in pci_device_add()
drivers/pci/remove.c	✅ PASS	Calls platform_pci_remove_wake() in pci_destroy_dev()
include/linux/of_pci.h	✅ PASS	Adds function declarations with CONFIG_OF_IRQ guards
include/linux/pci.h	✅ PASS	Adds struct gpio_desc *wake field to struct pci_dev

Issues

1. Dependency failure — Line 163 in drivers/pci/of.c calls fwnode_gpiod_get(), but this function is not defined anywhere in the PR. Commit 1 was supposed to provide it but is empty.

---

Upstream Patch Status

Commit	Community Verdict
gpio: Add fwnode_gpiod_get() helper	⏳ Decision Pending (unknown) — cannot fetch lore thread due to network restrictions
PCI: Add support for PCIe WAKE# interrupt	⏳ Decision Pending (unknown) — cannot fetch lore thread due to network restrictions

Note: The lore links reference a v10 series posted on 2026-05-11. The commit messages include formal review tags (Reviewed-by: Linus Walleij, Acked-by: Bartosz Golaszewski, Acked-by: Manivannan Sadhasivam), suggesting the patches have received maintainer approval. However, without network access to lore.kernel.org or torvalds/linux, I cannot confirm whether they have been merged into mainline.

---

qcom-next Presence

Commit	Status
gpio: Add fwnode_gpiod_get() helper	⚠️ Not in qcom-next
PCI: Add support for PCIe WAKE# interrupt	⚠️ Not in qcom-next

Note: Searched /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel (origin/qcom-next branch). Neither commit is present yet.

---

Verdict

❌ DO NOT MERGE — This PR has a critical structural defect that will cause build failures.

Root cause: Commit 1 is an empty commit (zero diff hunks) despite claiming to add fwnode_gpiod_get() helper. Commit 2 depends on this function and will fail to compile.

Required fix:

1. Verify that commit 1 should contain a diff adding fwnode_gpiod_get() to drivers/gpio/gpiolib-devres.c or similar gpio subsystem file.
2. Re-generate the PR patch with the correct diff content for commit 1.
3. Alternatively, if fwnode_gpiod_get() already exists in the target branch, remove commit 1 entirely and update commit 2's commit message to note the dependency.

Additional observations:

• Both commits follow FROMLIST authorship rules correctly (original author in Signed-off-by, submitter in From: for commit 1).
• Commit messages are well-structured with proper Link: tags and review trailers.
• The v10 series has received multiple Acked-by/Reviewed-by tags from subsystem maintainers, indicating likely upstream acceptance, but this cannot be confirmed without network access.

---

Final Summary

1. Lore link present: Yes — both commits have valid lore.kernel.org Link: tags
2. Lore link matches PR commits: Cannot verify — network access restricted; however, commit 1 is empty (zero diff) which is almost certainly incorrect
3. Upstream patch status: Unknown — cannot fetch lore threads or search mainline due to network restrictions; review tags suggest maintainer approval
4. PR present in qcom-next: No — neither commit found in origin/qcom-next

[qlijarvis]

PR #1442 — checker-log-analyzer

PR: #1442
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28778824423

Checker	Result	Summary
Checker	Result	Summary
checkpatch	⚠️	CI infrastructure failure - merge failed
dt-binding-check	⚠️	CI infrastructure failure - merge failed
dtb-check	⚠️	CI infrastructure failure - merge failed
sparse-check	⚠️	CI infrastructure failure - merge failed
check-uapi-headers	⚠️	CI infrastructure failure - merge failed
check-patch-compliance	⚠️	CI infrastructure failure - merge failed
tag-check	N/A	Cannot verify - CI did not run

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1442 - FROMLIST: PCI: Add support for PCIe WAKE# interrupt
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28778824423

Checker	Result	Summary
checkpatch	⚠️	CI infrastructure failure - merge failed
dt-binding-check	⚠️	CI infrastructure failure - merge failed
dtb-check	⚠️	CI infrastructure failure - merge failed
sparse-check	⚠️	CI infrastructure failure - merge failed
check-uapi-headers	⚠️	CI infrastructure failure - merge failed
check-patch-compliance	⚠️	CI infrastructure failure - merge failed
tag-check	N/A	Cannot verify - CI did not run

---

⚠️ CI Infrastructure Failure

Root cause: Git merge failure with "refusing to merge unrelated histories" during CI setup phase.

Failure details:

All checker jobs failed at the merge stage before any actual checking could occur:

Create a new integration branch based on 19b282f417584cfe14ce6a262122c51553d026ec
Switched to a new branch 'integ'
Merging topic branches...
------------------------------------------
 ** Merging topic branch: topic/tech/bus/pci/all
fatal: refusing to merge unrelated histories
Merge failed, manual merge
...
Fetching PR #1442 from https://github.com/qualcomm-linux/kernel-topics.git...
From https://github.com/qualcomm-linux/kernel-topics
 * [new ref]                   refs/pull/1442/head -> pr-1442
Merging pr-1442 (no-commit)...
fatal: refusing to merge unrelated histories
Merge failed or conflicts detected. Aborting merge.
##[error]Process completed with exit code 3.

The error occurs in two places:

1. When merging the topic branch topic/tech/bus/pci/all into the integration branch
2. When merging PR FROMLIST: gpio: Add fwnode_gpiod_get() helper #1442 into the integration branch

Analysis:

This is a CI infrastructure/configuration issue, not a patch quality problem. The "refusing to merge unrelated histories" error indicates that:

• The PR branch and the base integration branch do not share a common ancestor in their Git history
• This typically happens when:
  • The PR was created from an orphan branch
  • The base branch was force-pushed or rebased, breaking history continuity
  • The topic branch topic/tech/bus/pci/all has an incompatible history with the baseline

Impact:

• No checkers were able to run - all jobs failed during the merge setup phase
• No patch quality assessment is possible from this CI run
• The patches themselves appear well-formed (both have FROMLIST: prefix, proper commit messages, and Link: tags)

Fix:

This requires investigation and resolution at the repository/CI configuration level:

1. Verify the PR base branch:

   gh pr view 1442 --repo qualcomm-linux/kernel-topics --json baseRefName -q .baseRefName

2. Check if the PR branch shares history with the base:

   git merge-base --is-ancestor <base-sha> <pr-sha>

3. Possible resolutions:

   • Rebase the PR on the correct base branch
   • Fix the topic branch topic/tech/bus/pci/all history
   • Update the CI configuration to use --allow-unrelated-histories if this is intentional
   • Re-create the PR from the correct base

Reproduce locally:

Cannot reproduce the checker failures locally because the merge itself fails. To investigate:

# Clone and attempt the same merge the CI is doing
git clone https://github.com/qualcomm-linux/kernel-topics.git
cd kernel-topics
git checkout 19b282f417584cfe14ce6a262122c51553d026ec
git checkout -b integ
git fetch origin refs/pull/1442/head:pr-1442
git merge pr-1442 --no-commit
# This will likely fail with "refusing to merge unrelated histories"

---

Verdict

Cannot assess patch quality - CI infrastructure failure prevents all checkers from running. The merge failure must be resolved before the patches can be validated. Based on manual inspection of pr.patch, the commits appear properly formatted with FROMLIST: prefixes and upstream links, but automated verification is blocked by the merge issue.

Recommended action: Investigate and fix the Git history incompatibility, then re-trigger the CI run.

[qswat-orbit-external]

Merge Check Failed: No Component Found

Configuration Error: No component found for branch 'tech/bus/pci/all'.

There is no component associated with the provided branch in Polaris. Please verify the branch configuration.

Branch: tech/bus/pci/all

[qswat-orbit-external]

Merge Check Failed: No Component Found

Configuration Error: No component found for branch 'tech/bus/pci/all'.

There is no component associated with the provided branch in Polaris. Please verify the branch configuration.

Branch: tech/bus/pci/all

[qlijarvis]

🔨 Build Failure Analysis — PR #1442

PR: #1442
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28781755891

#	Error	File:Line	PR-introduced?	Root Cause
N/A	Merge conflict (not compilation error)	Multiple files (101 conflicts)	No	Integration conflict between PR branch tech/bus/pci/all and baseline qcom-next

Verdict

This is not a compilation failure. The build failed during the pre-build integration phase when attempting to merge the PR branch with the baseline. The automerge tool encountered 101 merge conflicts across devicetree bindings, drivers, and other subsystems. No compilation was attempted because the merge could not complete.

📎 Detailed analysis: Full report

[qlijarvis]

🔨 Build Failure Analysis — PR #1442

PR: #1442
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28781755891

#	Error	File:Line	PR-introduced?	Root Cause
N/A	Merge conflict (not a compilation error)	Multiple files	N/A	The CI build system attempted to merge branch topic/tech/bus/pci/all with baseline 19b282f417584cfe14ce6a262122c51553d026ec using an automerge tool, resulting in 100+ merge conflicts across devicetree bindings, drivers, and include files. The build never reached compilation stage.

Verdict

This is not a compilation failure. The build failed during the pre-build merge/integration phase due to extensive merge conflicts between the PR branch and the integration baseline. No compilation errors occurred because the merge conflicts prevented the build from starting.

📎 Detailed analysis: Full report

[qlijarvis]

PR #1442 — validate-patch

PR: #1442

Verdict	Issues	Detailed Report
⚠️	3	Full report

Final Summary

1. Lore link present: Yes — https://lore.kernel.org/r/20260511-wakeirq_support-v10-1-c10af9c9eb8c@oss.qualcomm.com (v10 of wakeirq_support series, patch 1)
2. Lore link matches PR commits: Cannot verify — network restricted; pr.patch contains no diff section
3. Upstream patch status: Cannot verify — network restricted; commit message shows strong acceptance signals (Reviewed-by: Linus Walleij, Acked-by: Bartosz Golaszewski + Manivannan Sadhasivam) suggesting likely acceptance, but cannot confirm merge status
4. PR present in qcom-next: Cannot verify — network restricted; cannot access qualcomm-linux/kernel repository

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1442 — FROMLIST: gpio: Add fwnode_gpiod_get() helper
Upstream commit: https://lore.kernel.org/r/20260511-wakeirq_support-v10-1-c10af9c9eb8c@oss.qualcomm.com
Verdict: ⚠️ PARTIAL (network restricted — full validation incomplete)

Commit Message

Check	Status	Note
Subject matches upstream	⏭️	Cannot verify — network restricted, lore.kernel.org unreachable
Body preserves rationale	✅	Clear description: convenience wrapper for fwnode_gpiod_get_index
Fixes tag present/correct	N/A	Not a bug fix; new feature addition
Authorship preserved	✅	FROMLIST: original author (Krishna Chaitanya Chundru) present in Signed-off-by; submitter (Ziyue Zhang) correctly added second Signed-off-by
Backport note (if applicable)	N/A	FROMLIST prefix — not a backport

Diff

File	Status	Notes
(unknown)	⏭️	pr.patch contains only commit message; no diff section present

Issues

• Cannot verify diff content: The pr.patch file contains only the commit message without the actual code changes. Full validation requires the complete patch diff.
• Network restricted: Cannot fetch upstream lore patch via b4 or curl to compare commit message and diff content.
• Cannot check qcom-next presence: Network restriction prevents checking if this commit is already in the qcom-next branch.

Verdict

Incomplete validation due to environment constraints. Based on commit message analysis alone:

Positive signals:

• Lore link present and well-formed (v10 of wakeirq_support series)
• FROMLIST prefix appropriate for patches posted but not yet merged
• Strong maintainer support: Reviewed-by from Linus Walleij (GPIO maintainer), Acked-by from Bartosz Golaszewski (GPIO co-maintainer) and Manivannan Sadhasivam
• Authorship chain correct for FROMLIST: original author in first Signed-off-by, submitter in second
• Commit message structure follows kernel conventions

Cannot verify:

• Whether PR diff matches upstream lore patch (no diff in pr.patch, network blocked)
• Upstream acceptance status (cannot fetch lore thread to check for merge signals)
• Presence in qcom-next branch (network blocked)

Recommendation: This commit message is well-formed and shows strong upstream acceptance signals (multiple Acks/Reviewed-by from maintainers). However, full validation requires: (1) complete patch diff, (2) network access to fetch and compare upstream lore patch, (3) access to qcom-next to verify presence.

Final Summary

1. Lore link present: Yes — https://lore.kernel.org/r/20260511-wakeirq_support-v10-1-c10af9c9eb8c@oss.qualcomm.com (v10 of wakeirq_support series, patch 1)
2. Lore link matches PR commits: Cannot verify — network restricted; pr.patch contains no diff section
3. Upstream patch status: Cannot verify — network restricted; commit message shows strong acceptance signals (Reviewed-by: Linus Walleij, Acked-by: Bartosz Golaszewski + Manivannan Sadhasivam) suggesting likely acceptance, but cannot confirm merge status
4. PR present in qcom-next: Cannot verify — network restricted; cannot access qualcomm-linux/kernel repository

[qlijarvis]

PR #1442 — checker-log-analyzer

PR: #1442
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28781755720

Checker	Result	Summary
Checker	Result	Summary
checkpatch	⏭️	Did not run - automerge failed
dt-binding-check	⏭️	Did not run - automerge failed
dtb-check	⏭️	Did not run - automerge failed
sparse-check	⏭️	Did not run - automerge failed
check-uapi-headers	⏭️	Did not run - automerge failed
check-patch-compliance	⏭️	Did not run - automerge failed
tag-check	N/A	Cannot determine target branch (network restricted)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1442 - FROMLIST: gpio: Add fwnode_gpiod_get() helper
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28781755720

Checker	Result	Summary
checkpatch	⏭️	Did not run - automerge failed
dt-binding-check	⏭️	Did not run - automerge failed
dtb-check	⏭️	Did not run - automerge failed
sparse-check	⏭️	Did not run - automerge failed
check-uapi-headers	⏭️	Did not run - automerge failed
check-patch-compliance	⏭️	Did not run - automerge failed
tag-check	N/A	Cannot determine target branch (network restricted)

---

❌ CI Infrastructure Failure — Automerge Step

Root cause: All checker jobs failed during the pre-merge automerge/integration step with fatal: refusing to merge unrelated histories. No actual code checking was performed.

Failure details:

2026-07-06T09:48:25.1496957Z  ** Merging topic branch: topic/tech/bus/pci/all
2026-07-06T09:48:42.9383626Z fatal: refusing to merge unrelated histories
2026-07-06T09:48:43.0424813Z Merge failed, manual merge
...
2026-07-06T09:48:43.9664707Z Merging pr-1442 (no-commit)...
2026-07-06T09:49:02.9782654Z fatal: refusing to merge unrelated histories
2026-07-06T09:49:03.0823590Z Merge failed or conflicts detected. Aborting merge.
2026-07-06T09:49:03.0860985Z ##[error]Process completed with exit code 3.

This error occurred in all six checker jobs:

• checker__checkpatch (exit code 3)
• checker__dt-binding-check (exit code 3)
• checker__dtb-check (exit code 3)
• checker__sparse-check (exit code 3)
• checker__check-uapi-headers (exit code 3)
• checker__check-patch-compliance (exit code 3)

Analysis:

The "refusing to merge unrelated histories" error indicates that:

1. The CI workflow attempted to create an integration branch by merging topic/tech/bus/pci/all into a baseline commit (19b282f417584cfe14ce6a262122c51553d026ec)
2. Git refused the merge because the topic branch and baseline have no common ancestor (unrelated histories)
3. After the topic merge failed, the PR merge also failed with the same error
4. Because the integration branch could not be created, none of the actual checker scripts (checkpatch.pl, dt_binding_check, sparse, etc.) were executed

This is a CI infrastructure/configuration issue, not a defect in PR #1442's code.

Fix:

This requires CI workflow or repository configuration changes:

1. Immediate workaround: Re-trigger the CI run. If the topic branch issue persists, the workflow may need to skip the problematic topic branch or use --allow-unrelated-histories.

2. Root cause fix: Investigate why topic/tech/bus/pci/all has unrelated history to the baseline. Possible causes:

   • The topic branch was force-pushed or rebased, breaking its ancestry
   • The baseline tag/commit is from a different repository or fork
   • The automerge configuration file references an incompatible topic branch

3. Verify the automerge configuration: Check the .conf file used by the automerge tool to ensure topic/tech/bus/pci/all is appropriate for this integration.

Reproduce locally:

# Clone the kernel tree
git clone https://github.com/qualcomm-linux/kernel-topics.git
cd kernel-topics

# Checkout the baseline
git checkout 19b282f417584cfe14ce6a262122c51553d026ec
git checkout -b test-integ

# Try to merge the topic branch
git fetch origin tech/bus/pci/all:topic/tech/bus/pci/all
git merge topic/tech/bus/pci/all
# This will fail with "refusing to merge unrelated histories"

# Check if histories are truly unrelated
git merge-base 19b282f417584cfe14ce6a262122c51553d026ec topic/tech/bus/pci/all
# If this returns nothing, the branches have no common ancestor

---

Verdict

Cannot assess PR quality — all checkers failed before execution due to a CI infrastructure issue (automerge failure with unrelated histories).

Action required: CI workflow maintainers must fix the automerge configuration or topic branch ancestry issue, then re-trigger the checker run. The PR code itself cannot be evaluated until the checkers successfully run.