qp_lvgl: always signal flush ready even with no display#26275
Open
arcaartem wants to merge 1 commit into
Open
Conversation
qp_lvgl_flush() called lv_disp_flush_ready() only inside the `if (selected_display)` block. When LVGL invokes the flush callback while selected_display is NULL, the callback returns without ever signalling completion, so LVGL keeps the flush marked "in progress" and stalls all further rendering. Move lv_disp_flush_ready() out of the conditional so it is always called, per LVGL's contract that every flush_cb must signal ready exactly once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
qp_lvgl_flush()calledlv_disp_flush_ready()only inside theif (selected_display)block. When LVGL invokes the flush callback whileselected_displayisNULL, the callback returns without ever signallingcompletion, so LVGL keeps the flush marked "in progress" and stalls all
further rendering.
This moves
lv_disp_flush_ready()out of the conditional so it is alwayscalled, per LVGL's contract that every
flush_cbmust signal ready exactlyonce.
Types of Changes
Checklist