Handle ASCII in send_unicode_string with keycodes#26272
Open
nkgotcode wants to merge 1 commit into
Open
Conversation
drashna
approved these changes
Jun 18, 2026
tzarc
requested changes
Jun 18, 2026
| str = decode_utf8(str, &code_point); | ||
|
|
||
| if (code_point >= 0) { | ||
| if (code_point > 0 && code_point < 0x80 && pgm_read_byte(&ascii_to_keycode_lut[code_point]) != XXXXXXX) { |
Member
There was a problem hiding this comment.
Let's use the actual keycode.
Suggested change
| if (code_point > 0 && code_point < 0x80 && pgm_read_byte(&ascii_to_keycode_lut[code_point]) != XXXXXXX) { | |
| if (code_point > 0 && code_point < 0x80 && pgm_read_byte(&ascii_to_keycode_lut[code_point]) != KC_NO) { |
Member
There was a problem hiding this comment.
The logic is also better encapsulated if its implemented within quantum/send_string/send_string.{h,c} as something like is_valid_send_char().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates
send_unicode_string()to emit ASCII characters through QMK's existing send-string keycode path when the decoded character has a keycode mapping. Non-ASCII characters continue to use the configured Unicode input mode.Fixes #25382
Types of Changes
Issues Fixed or Closed by This PR
Checklist