Clear weak mods before processing queued keypresses in tap-hold handling#26214
Open
windexlight wants to merge 2 commits into
Open
Clear weak mods before processing queued keypresses in tap-hold handling#26214windexlight wants to merge 2 commits into
windexlight wants to merge 2 commits into
Conversation
Fixes sending modified keycodes erroneously when, for example, activiting a layer with LT, and then rapidly typing a modified keycode followed by a non-modified keycode within the tapping term. Example: trying to type != and getting !+ instead.
drashna
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
action_exec(), there is a bit of code that clears weak mods left over from previous keypresses, so they do not affect new keypresses. However, tap-hold handling code buffers events so that they can be processed after a tap-hold decision is settled. The processing of these buffered events bypassesaction_exec(), so weak mods from a keypress in the buffer can affect those processed later in the buffer. This can manifest when activating a layer with LT, and then rapidly typing a modified keycode followed by a non-modified keycode within the tapping term. Example: trying to type != and getting !+ instead.Have implemented a fix by clearing weak mods before passing buffered records on for processing.
Types of Changes
Issues Fixed or Closed by This PR
Checklist