Skip to content

Update docker workflow to actually run tests inside built container #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zvecr wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update docker workflow to actually run tests inside built container #237

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b015d7
Update docker workflow to actually run tests inside built container
zvecr Jun 3, 2026
f078db9
Fix?
zvecr Jun 3, 2026
b9085de
Fix?
zvecr Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions .github/workflows/docker-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ name: Test Docker Image
on:
pull_request:

env:
TEST_TAG: qmkfm/qmk_cli:test

jobs:
test:

Expand All @@ -22,9 +25,6 @@ jobs:

- uses: actions/checkout@v6

- name: Run ci_tests
run: ./ci_tests

- name: Install dependencies
run: |
python3 -m pip install --upgrade pip
Expand All @@ -35,7 +35,18 @@ jobs:
run: |
python3 -m build

- name: Build Container
- name: Build Test Container
uses: docker/build-push-action@v7
with:
context: .
load: true
tags: ${{ env.TEST_TAG }}

- name: Test
run: |
docker run --rm ${{ env.TEST_TAG }} qmk setup -y

- name: Build All Containers
uses: docker/build-push-action@v7
with:
context: .
Expand Down
Loading