Add a unit test for the CO2 corrector #3371
CodeScene PR Check
Quality Gate Failed
(1 files improve in Code Health)
Gates Failed
(1 file with Excess Number of Function Arguments)
Gates Passed
See analysis details in CodeScene
Reason for failure
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| test_atmosphere.py | 1 advisory rule | 9.69 | Suppress |
View Improvements
| File | Code Health Impact | Categories Improved |
|---|---|---|
| test_modifiers.py | 9.10 → 9.39 | Excess Number of Function Arguments |
Quality Gate Profile: Clean Code Collective
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Excess Number of Function Arguments test_atmosphere.py: TestPSPRayleighReflectance.test_rayleigh_corrector
✅ Improving Code Health:
- Excess Number of Function Arguments test_modifiers.py: TestPSPRayleighReflectance.test_rayleigh_corrector
Annotations
Check warning on line 132 in satpy/tests/modifier_tests/test_atmosphere.py
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Excess Number of Function Arguments
TestPSPRayleighReflectance.test_rayleigh_corrector has 9 arguments, max arguments = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Check notice on line 425 in satpy/tests/test_modifiers.py
codescene-delta-analysis / CodeScene Code Health Review (main)
✅ No longer an issue: Excess Number of Function Arguments
TestPSPRayleighReflectance.test_rayleigh_corrector is no longer above the threshold for number of arguments