fix GCC 15 build by including <cstdint>#508
Conversation
|
Hi @gouzil! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates Gloo headers to add missing standard library includes needed by recent changes and to normalize TCP transport device includes.
Changes:
- Add
<cstdint>include togloo/types.h. - Add
<array>include togloo/transport/tcp/device.cc.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| gloo/types.h | Adds <cstdint> to support fixed-width integer types usage in the header. |
| gloo/transport/tcp/device.cc | Adds <array> include to support std::array usage in TCP device implementation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| #include "gloo/transport/tcp/device.h" | ||
|
|
||
| #include <array> | ||
| #include <ifaddrs.h> | ||
| #include <netdb.h> | ||
| #include <netinet/in.h> |
Summary
本 PR 修复 GCC 15 下的构建问题,在
gloo/types.h中补充直接依赖的<cstdint>头文件。Changes
gloo/types.h中添加#include <cstdint>。background
gloo/types.h使用了固定宽度整数类型,但此前没有直接包含<cstdint>。GCC 15 下该依赖不再能稳定通过其他头文件间接获得,因此会暴露缺失头文件导致的编译失败。相关链接: