Fix OOB read in _get_padding_value_kernel#5652
Closed
cyyever wants to merge 3 commits intopytorch:mainfrom
Closed
Conversation
cyyever
force-pushed
the
fix/fp8-rowwise-oob-read
branch
from
13fdeb9 to
d4f30b1
Compare
Contributor
|
@cyyever can you add a unit test to exercise this case? |
cyyever
changed the title
Contributor
Author
|
@q10 existing tests has covered the normal case, let me add some edge cases. |
Contributor
|
@q10 has imported this pull request. If you are a Meta employee, you can view this in D101380325. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.