Repository navigation
Fix executor initializer attribute return types - #16805
Merged
srittau merged 2 commits intoNov 15, 2026
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
srittau
requested changes
Nov 14, 2026
srittau
left a comment
Collaborator
There was a problem hiding this comment.
Please remove the tests. In typeshed, we only add regression tests for functions and classes which are known to have caused complex problems in the past, or where stubs are difficult to get right. 100% test coverage for typeshed is neither necessary nor desirable, as it would lead to code duplication.
See tests/REGRESSION.md for more information.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11400.
Change the stored
_initializerattributes fromCallable[..., None] | NonetoCallable[..., object] | Noneto match the constructor annotations, accepting value-returning callbacks while retaining checks for non-callables and mismatched constructorinitargs.CPython stores the callable unchanged and ignores its result (process executor, thread executor through 3.13); the thread attribute was removed in 3.14.
Verified locally:
python tests/runtests.py stdlib/concurrent: all checks passed, including pre-commit, structure, mypy, pyright, ty, pyrefly, stubtest, and regression suites.Agent used: OpenAI Codex.