Skip to content

Preserve text and byte nmap scan output types - #16803

Closed
iamabhisheknag wants to merge 1 commit into
python:mainfrom
iamabhisheknag:fix/nmap-scan-output-types
Closed

iamabhisheknag wants to merge 1 commit into
python:mainfrom
iamabhisheknag:fix/nmap-scan-output-types

Conversation

@iamabhisheknag

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau

srittau commented Nov 14, 2026

Copy link
Copy Markdown
Collaborator

This is clearly meant to work on str only. Returning str | bytes makes using this library harder for no necessary reason.

@srittau srittau closed this Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants