Skip to content

Changes for schema registry for BPM - #330

Merged
gubaidulinvadim merged 7 commits into
mainfrom
schema-registry-bpm
Aug 7, 2026
Merged

Changes for schema registry for BPM#330
gubaidulinvadim merged 7 commits into
mainfrom
schema-registry-bpm

Conversation

@TeresiaOlsson

Copy link
Copy Markdown
Member

Changes required for the schema registry and removing the config module for BPM.

@TeresiaOlsson TeresiaOlsson linked an issue Jul 10, 2026 that may be closed by this pull request
@TeresiaOlsson

Copy link
Copy Markdown
Member Author

I'm wondering about the new docstring for the BPM. They were based on the docstrings for the ConfigModel but they say that all attributes should be catalog keys. But what if you are not using a catalog?

@TeresiaOlsson TeresiaOlsson self-assigned this Jul 10, 2026
Base automatically changed from schema-registry-rf to main July 24, 2026 13:09
@JeanLucPons

Copy link
Copy Markdown
Member
from pyaml.accelerator import Accelerator
sr = Accelerator.load("tests/config/EBSOrbit.yaml")
SR = sr.design
print( SR.get_bpm("BPM_C04-04") )

before:

BPM(peer='Simulator:design', name='BPM_C04-04', description=None, lattice_names=None, x_pos='srdiag/bpm/c04-04/SA_HPosition', y_pos='srdiag/bpm/c04-04/SA_VPosition', x_offset=None, y_offset=None, tilt=None)

after:

BPM(name='BPM_C04-04')

@gubaidulinvadim
gubaidulinvadim self-requested a review August 6, 2026 08:47
@gubaidulinvadim

gubaidulinvadim commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

@JeanLucPons which configuration file have you used to check that? I'm having trouble with reviewing Teresia's merge request as none of the config files in examples (SOLEIL or BESSY) seems to load the accelerator. (including EBSorbit.yaml from tests/)

@JeanLucPons

Copy link
Copy Markdown
Member

I used the simple program example that I mentioned that loads "tests/config/EBSOrbit.yaml".
The problem is that some information are lost in __repr__.
It is a choice from Teresia.
Typically the peer is interesting because you know to what your object is attached.
You can also filter by fields in ElementArray.
But now, there is only the name.

@gubaidulinvadim gubaidulinvadim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made an issue #345 for string representation with the new configuration and I will try to find a solution to get string representation close to what it was before without loss of information.

@gubaidulinvadim
gubaidulinvadim merged commit 8cb2c31 into main Aug 7, 2026
4 checks passed
@gubaidulinvadim
gubaidulinvadim deleted the schema-registry-bpm branch August 7, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove ConfigModel from BPM

3 participants