Repository navigation
build(deps): bump bcrypt from 3.1.7 to 5.0.0 in the security group across 1 directory - #595
Merged
Merged
Conversation
dependabot
Bot
added
dependencies
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
dependabot
Bot
changed the title
dependabot
Bot
force-pushed
the
dependabot/uv/main/security-d135905752
branch
from
May 15, 2026 11:13
a263173 to
1b59043
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #595 +/- ##
==========================================
+ Coverage 90.09% 90.12% +0.03%
==========================================
Files 55 55
Lines 2503 2512 +9
==========================================
+ Hits 2255 2264 +9
Misses 248 248 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MateoLostanlen
force-pushed
the
dependabot/uv/main/security-d135905752
branch
2 times, most recently
from
May 15, 2026 11:46
fb72113 to
efe191f
Compare
passlib 1.7.4 imports bcrypt.__about__ at module load to detect the bcrypt version. That attribute was removed in bcrypt 4.x, so once the dependabot bcrypt 5.0.0 bump lands, passlib raises AttributeError on import and the backend fails its health check at startup. passlib is effectively unmaintained (last release 2020). Rather than work around the import, replace the CryptContext usage in src/app/core/security.py with direct bcrypt calls — the API surface we use is just hashpw/checkpw plus a salt. To stay drop-in compatible with hashes generated by the previous passlib-based code, hash_password / verify_password silently truncate the password to 72 bytes (bcrypt's hard limit, which passlib used to swallow) and verify_password catches the ValueError that bcrypt 5.x now raises on malformed stored hashes, returning False instead — so a corrupt DB row produces 401, not 500. Both behaviours are covered by new regression tests in src/tests/test_security.py.
MateoLostanlen
force-pushed
the
dependabot/uv/main/security-d135905752
branch
from
May 15, 2026 12:09
efe191f to
4b7908a
Compare
MateoLostanlen
approved these changes
May 15, 2026
MateoLostanlen
left a comment
MateoLostanlen
left a comment
Member
There was a problem hiding this comment.
Approving — passlib dropped, bcrypt 5.0 used directly with 72-byte truncation and ValueError catching to match prior passlib semantics. Backward-compatible with existing hashes. Regression tests cover both edge cases. CI 23/23 green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the security group with 1 update in the / directory: bcrypt.
Updates
bcryptfrom 3.1.7 to 5.0.0Changelog
Sourced from bcrypt's changelog.
... (truncated)
Commits
5060bce5.0.0 release (#1078)e43f568Bump actions/cache from 4.2.4 to 4.3.0 (#1077)fc9f680Bump libc from 0.2.175 to 0.2.176 in /src/_bcrypt (#1075)633f46fAdd support for Python 3.14 (#1073)a2fefbbRemove pypy310 builds (#1074)f60707eBump wasi from 0.14.5+wasi-0.2.4 to 0.14.7+wasi-0.2.4 in /src/_bcrypt (#1071)c790eedBump unicode-ident from 1.0.18 to 1.0.19 in /src/_bcrypt (#1070)122cbdcBump target-lexicon from 0.13.2 to 0.13.3 in /src/_bcrypt (#1069)2bd208dBump wasi from 0.14.4+wasi-0.2.4 to 0.14.5+wasi-0.2.4 in /src/_bcrypt (#1068)e1aa9e8remove poinless cargo cache paths from CI (#1067)