Allow editable installs to satisfy direct-URL dependencies#13888
Open
Allow editable installs to satisfy direct-URL dependencies#13888
Conversation
When a transitive dependency referenced a package by direct URL and the same package was also requested as editable, the resolver saw two distinct candidate types for the same link and raised `ResolutionImpossible`. An editable install subsumes a non-editable direct URL request to the same location, so `_make_base_candidate_from_link` now returns the cached `EditableCandidate` in that case.
pradyunsg
commented
Apr 6, 2026
Comment on lines
+223
to
224
| elif link in self._editable_candidate_cache: | ||
| return self._editable_candidate_cache[link] |
Member
Author
There was a problem hiding this comment.
I didn't come up with this -- I tried using Claude Code to resolve this one and it ended up coming up with this... and, like I don't see anything wrong with this particular change logically and it's too nice and small to not consider. 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10216
Fixes #12533