Fix BrokenPipeError crash when pip output is piped#13881
Closed
Fix BrokenPipeError crash when pip output is piped#13881
Conversation
When pip output is piped to a process that exits early (e.g. `pip show pip | head -1`), Python raises BrokenPipeError. This was not caught explicitly, causing it to fall through to the BaseException handler which logs a verbose traceback. Fix by catching BrokenPipeError before BaseException and exiting cleanly, following Python's SIGPIPE convention (PEP 389). Closes #13877
Member
|
There is already an almost identical PR: https://github.com/pypa/pip/pull/13878/changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When pip's output is piped to a command that exits early, pip crashes with an uncaught
BrokenPipeError:Fix
Catch
BrokenPipeErrorexplicitly beforeBaseExceptionand exit cleanly.Closing in favor of #13878 which was opened earlier and addresses the same issue.