Skip to content

Upgrade requests to 2.33.0#13872

Closed
jayaddison wants to merge 4 commits intopypa:mainfrom
openculinary:maintenance/update-vendored-requests
Closed

Upgrade requests to 2.33.0#13872
jayaddison wants to merge 4 commits intopypa:mainfrom
openculinary:maintenance/update-vendored-requests

Conversation

@jayaddison
Copy link
Copy Markdown

Resources consulted:

  • The vendoring policy.
    • Modifications are only to vendored code.
    • The updated requests source code here was copied from a PyPI tarball download.
    • ...the only modifications to that are to apply pip customisations
    • ...and the requests.patch file is updated accordingly (it should apply cleanly and also reverse-apply cleanly).
  • (briefly) The contributing guide, to check NEWS fragment details.
  • The recently-added AI policy.
    • I have not used any LLMs to contribute this code.

NB: For code review purposes, here is a hyperlink to the version range comparison v2.32.5...v2.33.0 in the requests source repo; changes to files within src should correspond to the suggested changes here very closely: psf/requests@v2.32.5...v2.33.0

@ichard26
Copy link
Copy Markdown
Member

Hi, thanks for the PR!

It looks like the requests patch is larger than it needs to be. Vendoring, the tool that largely automates vendoring for us, is able to rewrite from pkg.mod import name imports without help. It's only the import pkg.mod form that is unsafe to automatically rewrite, and thus requires a patch.

I can push a new patch file when I find some time later this week.

@jayaddison
Copy link
Copy Markdown
Author

@ichard26 one note is that, unless this has changed in the past ~1yr, it's not possible for maintainers to push commits to pull request branches opened from an organization account (as this one is). I don't mind you either re-using my commits, or starting from fresh - but I think it'll probably need to be a separate PR.

@sbidoul
Copy link
Copy Markdown
Member

sbidoul commented Apr 4, 2026

Done in #13882

@sbidoul sbidoul closed this Apr 4, 2026
@jayaddison
Copy link
Copy Markdown
Author

Thanks @sbidoul

@jayaddison jayaddison deleted the maintenance/update-vendored-requests branch April 4, 2026 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants