Closed
Conversation
jayaddison
commented
Mar 27, 2026
Member
|
Hi, thanks for the PR! It looks like the requests patch is larger than it needs to be. Vendoring, the tool that largely automates vendoring for us, is able to rewrite I can push a new patch file when I find some time later this week. |
Author
|
@ichard26 one note is that, unless this has changed in the past ~1yr, it's not possible for maintainers to push commits to pull request branches opened from an organization account (as this one is). I don't mind you either re-using my commits, or starting from fresh - but I think it'll probably need to be a separate PR. |
Member
|
Done in #13882 |
Author
|
Thanks @sbidoul |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resources consulted:
requestssource code here was copied from a PyPI tarball download.pipcustomisationsrequests.patchfile is updated accordingly (it should apply cleanly and also reverse-apply cleanly).NEWSfragment details.NB: For code review purposes, here is a hyperlink to the version range comparison
v2.32.5...v2.33.0in therequestssource repo; changes to files withinsrcshould correspond to the suggested changes here very closely: psf/requests@v2.32.5...v2.33.0